This is an archive of the discontinued LLVM Phabricator instance.

Fix clang-tidy bugprone-argument-comment that was mixed up
ClosedPublic

Authored by shafik on Jan 10 2022, 5:11 PM.

Details

Summary

Several of the comments were annotating the wrong argument.

I caught this while reviewing this clean-up: https://github.com/llvm/llvm-project/commit/8afcfbfb8fc1e53023ffac9d9bdc424248d6d2ff

which was changing booleans to use true and false and in the this case the comment and the type looked mismatched.

Diff Detail

Event Timeline

shafik requested review of this revision.Jan 10 2022, 5:11 PM
shafik created this revision.
JDevlieghere accepted this revision.Jan 10 2022, 9:56 PM

Good catch!

This revision is now accepted and ready to land.Jan 10 2022, 9:56 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 11:12 AM