This is an archive of the discontinued LLVM Phabricator instance.

Differential D116888

[libc] improve error message for unsupported target platforms
ClosedPublic

Authored by yannic on Jan 9 2022, 5:05 AM.

Details

Reviewers
michaelrj
ecnelises
tschuett
Commits
rGa01523ea9939: [libc] improve error message for unsupported target platforms

Diff Detail

Event Timeline

yannic created this revision.Jan 9 2022, 5:05 AM
Herald added subscribers: libc-commits, mgorny. · View Herald TranscriptJan 9 2022, 5:05 AM
yannic requested review of this revision.Jan 9 2022, 5:05 AM
Harbormaster completed remote builds in B142289: Diff 398417.Jan 9 2022, 5:09 AM
michaelrj accepted this revision.Jan 10 2022, 2:45 PM

LGTM, thank you for the patch.

This revision is now accepted and ready to land.Jan 10 2022, 2:45 PM
yannic added a comment.Jan 13 2022, 3:04 AM

Thanks for your review! I don't have commit access, could you help me to land this please?

Closed by commit rGa01523ea9939: [libc] improve error message for unsupported target platforms (authored by yannic, committed by michaelrj). · Explain WhyJan 19 2022, 10:39 AM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGa01523ea9939: [libc] improve error message for unsupported target platforms.

Revision Contents

PathSize
libc/
2 lines

Diff 401331

libc/CMakeLists.txt

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
include(LLVMLibCRules) include(LLVMLibCRules)
include(LLVMLibCCheckCpuFeatures) include(LLVMLibCCheckCpuFeatures)
if(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/entrypoints.txt") if(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/entrypoints.txt")
set(entrypoint_file "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/entrypoints.txt") set(entrypoint_file "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/entrypoints.txt")
elseif(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/entrypoints.txt") elseif(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/entrypoints.txt")
set(entrypoint_file "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/entrypoints.txt") set(entrypoint_file "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/entrypoints.txt")
else() else()
message(FATAL_ERROR "entrypoints.txt file for the target platform not found.") message(FATAL_ERROR "entrypoints.txt file for the target platform '${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}' not found.")
endif() endif()
include(${entrypoint_file}) include(${entrypoint_file})
if(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/headers.txt") if(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/headers.txt")
include("${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/headers.txt") include("${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/${LIBC_TARGET_ARCHITECTURE}/headers.txt")
elseif(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/headers.txt") elseif(EXISTS "${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/headers.txt")
include("${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/headers.txt") include("${LIBC_SOURCE_DIR}/config/${LIBC_TARGET_OS}/headers.txt")
endif() endif()
Show All 40 Lines