This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test] `movable` non-`view` rvalues become`viewable_range`s after P2415
AbandonedPublic

Authored by CaseyCarter on Jan 9 2022, 1:36 AM.

Details

Reviewers
Quuxplusone
Group Reviewers
Restricted Project
Summary

Update many test cases appropriately, guarding with #ifdef _LIBCPP_VERSION since libc++ doesn't yet implement P2415.

Diff Detail

Event Timeline

CaseyCarter requested review of this revision.Jan 9 2022, 1:36 AM
CaseyCarter created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJan 9 2022, 1:36 AM
Quuxplusone requested changes to this revision.Jan 9 2022, 3:30 AM
Quuxplusone added a subscriber: Quuxplusone.

This strikes me as the wrong fix; the right fix would be for someone to implement P2415R2 in libc++. I volunteer.
However, @CaseyCarter, could you tell me whether it is correct to implement P2415R2 in C++20 or only in C++23? I could totally believe it's one of these additions to C++20 that happened in Q4 of 2021, but I'm not sure where to look to find that out officially.

This revision now requires changes to proceed.Jan 9 2022, 3:30 AM

@CaseyCarter I suggest abandoning this in favour of https://reviews.llvm.org/D116894, which we will ship soon.

CaseyCarter abandoned this revision.Jan 11 2022, 11:42 AM

Superseded by D116894.