[CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

[paperchalice]

Summary

Try to fix https://github.com/llvm/llvm-project/issues/108

• Install python scripts into canonical resource path

[JDevlieghere]

Hey LJC. I'm the person maintaining the LLDB framework build, so please include me in any future patches that change that. I'm also on the majority of the blamelist for this file, which is always a useful way to find good reviewers. With that out of the way, I do have a few comments about this patch:

• It doesn't look like the RPATH change is really related to the install target so please create a separate patch for that.
• Note how the function this is (finish_swig_python) takes lldb_python_target_dir as an input argument. Downstream we create more than one directory, and this patch is going to break that.

You say that LLDB.framework/Resources/Python is installed by liblldb, but I can't immediately see where that's happening in API/CMakeLists.txt.

[paperchalice]

Install python scripts into canonical resource path.

[JDevlieghere]

Looks reasonable. LGTM.

[paperchalice]

Could you help me commit this change? Because I don't have permission. Thanks!

lldb/bindings/python/CMakeLists.txt

function(finish_swig_python swig_target lldb_python_bindings_dir lldb_python_target_dir)
   add_dependencies(${swig_target} swig_wrapper_python liblldb lldb-argdumper)
   set_target_properties(${swig_target} swig_wrapper_python PROPERTIES FOLDER "lldb misc")
 
   # Ensure we do the python post-build step when building lldb.
   add_dependencies(lldb ${swig_target})
 
   # Install the LLDB python module
   if(LLDB_BUILD_FRAMEWORK)
-    set(LLDB_PYTHON_INSTALL_PATH ${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Resources/Python)
+    set(LLDB_PYTHON_INSTALL_PATH ${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Versions/${LLDB_FRAMEWORK_VERSION}/Resources/Python)
   else()
     set(LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_RELATIVE_PATH})
   endif()
   if (NOT CMAKE_CFG_INTDIR STREQUAL  ".")
     string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_INSTALL_PATH})
     string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" lldb_python_target_dir ${lldb_python_target_dir})
   endif()
   set(python_scripts_target "${swig_target}-scripts")