Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D116722

[clang] Verify ssp buffer size is a valid integer
Needs ReviewPublic
Actions

Authored by alextsao1999 on Jan 5 2022, 8:48 PM.

Details

Reviewers
compnerd
Summary

This patch adds to verify whether the ssp buffer size is a legal integer and a new diagnostic driver kind has been added.

Diff Detail

Unit TestsFailed
View All

TimeTest
50 msx64 debian > LLVM.Bindings/Go::go.test

Event Timeline

alextsao1999 requested review of this revision.Jan 5 2022, 8:48 PM
alextsao1999 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 8:48 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B141827: Diff 397784.Jan 5 2022, 9:12 PM
compnerd added inline comments.Jan 7 2022, 10:18 AM
clang/lib/Driver/ToolChains/Clang.cpp
3204

I really am not a fan of the 16 here. Why not just use split and split on =? Or use [constexpr] strlen?

3209

Please consistently use the braces (either applied to both or on neither).

alextsao1999 updated this revision to Diff 398354.Jan 8 2022, 11:20 AM

update

Harbormaster completed remote builds in B142234: Diff 398354.Jan 8 2022, 11:53 AM
alextsao1999 marked 2 inline comments as done.Jan 28 2022, 11:05 PM
alextsao1999 added inline comments.
clang/lib/Driver/ToolChains/Clang.cpp
3209

Thanks, fixed. Are there any other issues?

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Basic/
2 lines
lib/
Driver/
ToolChains/
18 lines

Diff 397784

View Options

clang/include/clang/Basic/DiagnosticDriverKinds.td

Loading...
View Options

clang/lib/Driver/ToolChains/Clang.cpp

Loading...