[clang] Verify ssp buffer size is a valid integer
Needs ReviewPublic
Actions

Authored by alextsao1999 on Jan 5 2022, 8:48 PM.

Details

Reviewers

Summary

This patch adds to verify whether the ssp buffer size is a legal integer and a new diagnostic driver kind has been added.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	80 ms	x64 debian > LLVM.Bindings/Go::go.test Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm

Event Timeline

alextsao1999 requested review of this revision.Jan 5 2022, 8:48 PM

alextsao1999 created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2022, 8:48 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B141827: Diff 397784.Jan 5 2022, 9:12 PM

compnerd added inline comments.Jan 7 2022, 10:18 AM

clang/lib/Driver/ToolChains/Clang.cpp
3205–3210	I really am not a fan of the `16` here. Why not just use `split` and split on `=`? Or use [constexpr] `strlen`?
3210	Please consistently use the braces (either applied to both or on neither).

update

Harbormaster completed remote builds in B142234: Diff 398354.Jan 8 2022, 11:53 AM

alextsao1999 marked 2 inline comments as done.Jan 28 2022, 11:05 PM

alextsao1999 added inline comments.

clang/lib/Driver/ToolChains/Clang.cpp
3210	Thanks, fixed. Are there any other issues?

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

Basic/

DiagnosticDriverKinds.td

2 lines

lib/

Driver/

ToolChains/

Clang.cpp

21 lines

Diff 398354

View Options

clang/include/clang/Basic/DiagnosticDriverKinds.td