Page MenuHomePhabricator

[libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades
ClosedPublic

Authored by mstorsjo on Dec 21 2021, 2:54 PM.

Details

Summary

The test is currently marked XFAIL for mingw environments, but in
the future, it will start passing. (I'll update this with a reference
to the mingw-w64 commit once I've pushed it.)

The CI environment will probably be upgraded to a state where it is
passing only after 14.x is branched in the llvm-project monorepo.

If we'd just go from having an XFAIL to no marking at all (when CI is
passing), we'd have to update both main and 14.x branches in sync
exactly when the CI runners are updated to a newer version.

Instead, mark the test as temporarily unsupported (so it doesn't
cause failed builds when the CI environment is updated); after the
CI environments are upgraded to such a state, we can remove the
UNSUPPORTED marking to start requiring it to pass on the main branch,
without needing to synchronize that change to anything else.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Dec 21 2021, 2:54 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 2:54 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Dec 21 2021, 2:55 PM

Out of curiosity, are you coordinating on the update to the testing environment?

Please make a note to come back and remove this :-)

This revision is now accepted and ready to land.Dec 21 2021, 2:55 PM

Out of curiosity, are you coordinating on the update to the testing environment?

Please make a note to come back and remove this :-)

Yeah, I'll coordinate to update the CI images once 14.0.0 is out for both versions (clang-cl and llvm-mingw) that are packaged in the CI image, and remove this afterwards. (There's another XFAIL with a clang-13.0.0 version marking that we should be able to remove after that too.)