This is an archive of the discontinued LLVM Phabricator instance.

Differential D116119

[libc++] WIP fix to_chars with -fms-extensions.
AbandonedPublic

Authored by Mordante on Dec 21 2021, 10:11 AM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

The current code is just a test to see what breaks. The expectation was
that the current clang-cl build would already fail. Test whether adding
the explicit flag makes if fail there.

Fixes llvm.org/PR52709

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	2,830 ms	libcxx CI C++2b > llvm-libc++-shared-cfg-in.std/utilities/charconv/charconv_to_chars::integral.pass.cpp
	3,420 ms	libcxx CI MinGW (DLL) > libc++.std/utilities/charconv/charconv_to_chars::integral.pass.cpp
	2,630 ms	libcxx CI MinGW (Static) > libc++.std/utilities/charconv/charconv_to_chars::integral.pass.cpp

Event Timeline

Mordante created this revision.Dec 21 2021, 10:11 AM

Herald added a subscriber: arichardson. · View Herald TranscriptDec 21 2021, 10:11 AM

Mordante requested review of this revision.Dec 21 2021, 10:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 10:11 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B140283: Diff 395714.Dec 21 2021, 10:43 AM

Test building with -fms-extensions.

Harbormaster completed remote builds in B140414: Diff 395895.Dec 22 2021, 10:37 AM

At the moment I'm no longer interested to pursue this. Since the patch is tiny it makes more sense to create a new GitHub PR if needed.

Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2023, 9:05 AM

Revision Contents

Path

Size

libcxx/

test/

std/

utilities/

charconv/

charconv.to.chars/

integral.pass.cpp

1 line

utils/

ci/

buildkite-pipeline.yml

631 lines

Diff 395714

libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp

	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//
	//			//
	// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.			// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
	// See https://llvm.org/LICENSE.txt for license information.			// See https://llvm.org/LICENSE.txt for license information.
	// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception			// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
	//			//
	//===----------------------------------------------------------------------===//			//===----------------------------------------------------------------------===//

	// UNSUPPORTED: c++03			// UNSUPPORTED: c++03
	// UNSUPPORTED: !stdlib=libc++ && c++11			// UNSUPPORTED: !stdlib=libc++ && c++11
	// UNSUPPORTED: !stdlib=libc++ && c++14			// UNSUPPORTED: !stdlib=libc++ && c++14
				// ADDITIONAL_COMPILE_FLAGS: -fms-extensions

	// to_chars requires functions in the dylib that were introduced in Mac OS 10.15.			// to_chars requires functions in the dylib that were introduced in Mac OS 10.15.
	//			//
	// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9\|10\|11\|12\|13\|14}}			// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9\|10\|11\|12\|13\|14}}

	// <charconv>			// <charconv>

	// to_chars_result to_chars(char* first, char* last, Integral value,			// to_chars_result to_chars(char* first, char* last, Integral value,
	▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines

libcxx/utils/ci/buildkite-pipeline.yml

Show All 12 Lines
# into scripts. This is critical to being able to reproduce CI issues outside		# into scripts. This is critical to being able to reproduce CI issues outside
# of the CI environment, which is important for debugging.		# of the CI environment, which is important for debugging.
#		#
# It is also worth noting that this script is split into several sections, the		# It is also worth noting that this script is split into several sections, the
# goal being to reduce the load on testers when a commit is known to fail.		# goal being to reduce the load on testers when a commit is known to fail.
#		#

steps:		steps:
#
# Light pre-commit tests for things like formatting or when people forget
# to update generated files.
#
- label: "Format"
command: "libcxx/utils/ci/run-buildbot check-format"
artifact_paths:
- "**/clang-format.patch"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
soft_fail:
- exit_status: 1
timeout_in_minutes: 120

- label: "Generated output"
command: "libcxx/utils/ci/run-buildbot check-generated-output"
artifact_paths:
- "**/generated_output.patch"
- "**/generated_output.status"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

#
# General testing with the default configuration, under all the supported
# Standard modes, with Clang and GCC. This catches most issues upfront.
# The goal of this step is to catch most issues while being very fast.
#
- wait

- label: "C++2b"		- label: "C++2b"
command: "libcxx/utils/ci/run-buildbot generic-cxx2b"		command: "libcxx/utils/ci/run-buildbot generic-cxx2b"
artifact_paths:		artifact_paths:
- "**/test-results.xml"		- "**/test-results.xml"
- "*/.abilist"		- "*/.abilist"
agents:		agents:
queue: "libcxx-builders"		queue: "libcxx-builders"
os: "linux"		os: "linux"
retry:		retry:
automatic:		automatic:
- exit_status: -1 # Agent was lost		- exit_status: -1 # Agent was lost
limit: 2		limit: 2
timeout_in_minutes: 120		timeout_in_minutes: 120

- label: "C++20"
command: "libcxx/utils/ci/run-buildbot generic-cxx20"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "C++17"
command: "libcxx/utils/ci/run-buildbot generic-cxx17"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "C++14"
command: "libcxx/utils/ci/run-buildbot generic-cxx14"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "C++11"
command: "libcxx/utils/ci/run-buildbot generic-cxx11"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "C++03"
command: "libcxx/utils/ci/run-buildbot generic-cxx03"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "GCC 11 / C++latest"
command: "libcxx/utils/ci/run-buildbot generic-gcc"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

#
# All other supported configurations of libc++.
#
- wait

# Tests with the supported compilers.		# Tests with the supported compilers.
- label: "GCC 11 / C++11"		- label: "GCC 11 / C++11"
command: "libcxx/utils/ci/run-buildbot generic-gcc-cxx11"		command: "libcxx/utils/ci/run-buildbot generic-gcc-cxx11"
artifact_paths:		artifact_paths:
- "**/test-results.xml"		- "**/test-results.xml"
agents:		agents:
queue: "libcxx-builders"		queue: "libcxx-builders"
os: "linux"		os: "linux"
retry:		retry:
automatic:		automatic:
- exit_status: -1 # Agent was lost		- exit_status: -1 # Agent was lost
limit: 2		limit: 2
timeout_in_minutes: 120		timeout_in_minutes: 120

- label: "Clang 12"
command: "libcxx/utils/ci/run-buildbot generic-clang-12"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Clang 13"
command: "libcxx/utils/ci/run-buildbot generic-clang-13"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Tests with the sanitizers.
- label: "ASAN"
command: "libcxx/utils/ci/run-buildbot generic-asan"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "TSAN"
command: "libcxx/utils/ci/run-buildbot generic-tsan"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "UBSAN"
command: "libcxx/utils/ci/run-buildbot generic-ubsan"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Tests with the various supported ways to build libc++.
- label: "Bootstrapping build"
command: "libcxx/utils/ci/run-buildbot bootstrapping-build"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Legacy Lit configuration"
command: "libcxx/utils/ci/run-buildbot legacy-test-config"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Legacy standalone build"
command: "libcxx/utils/ci/run-buildbot legacy-standalone"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Legacy LLVM_ENABLE_PROJECTS build"
command: "libcxx/utils/ci/run-buildbot legacy-project-build"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Tests with various build configurations.
- label: "-fno-exceptions"
command: "libcxx/utils/ci/run-buildbot generic-noexceptions"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Modular build"
command: "libcxx/utils/ci/run-buildbot generic-modules"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Static libraries"
command: "libcxx/utils/ci/run-buildbot generic-static"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Assertions enabled"
command: "libcxx/utils/ci/run-buildbot generic-assertions"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Debug iterators"
command: "libcxx/utils/ci/run-buildbot generic-debug-iterators"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "With LLVM's libunwind"
command: "libcxx/utils/ci/run-buildbot generic-with_llvm_unwinder"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Single-threaded"
command: "libcxx/utils/ci/run-buildbot generic-singlethreaded"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "No debug mode"
command: "libcxx/utils/ci/run-buildbot generic-no-debug"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "No filesystem"
command: "libcxx/utils/ci/run-buildbot generic-no-filesystem"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "No random device"
command: "libcxx/utils/ci/run-buildbot generic-no-random_device"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "No locale"
command: "libcxx/utils/ci/run-buildbot generic-no-localization"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "No Unicode"
command: "libcxx/utils/ci/run-buildbot generic-no-unicode"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "No wide characters"
command: "libcxx/utils/ci/run-buildbot generic-no-wide-characters"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Other non-testing CI jobs
- label: "Benchmarks"
command: "libcxx/utils/ci/run-buildbot benchmarks"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Documentation"
command: "libcxx/utils/ci/run-buildbot documentation"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Tests on non-Unix platforms		# Tests on non-Unix platforms
- label: "Clang-cl (DLL)"		- label: "Clang-cl (DLL)"
command: "bash libcxx/utils/ci/run-buildbot clang-cl-dll"		command: "bash libcxx/utils/ci/run-buildbot clang-cl-dll"
artifact_paths:		artifact_paths:
- "**/test-results.xml"		- "**/test-results.xml"
agents:		agents:
queue: "windows"		queue: "windows"
retry:		retry:
Show All 32 Lines	artifact_paths:
- "**/test-results.xml"		- "**/test-results.xml"
agents:		agents:
queue: "windows"		queue: "windows"
retry:		retry:
automatic:		automatic:
- exit_status: -1 # Agent was lost		- exit_status: -1 # Agent was lost
limit: 2		limit: 2
timeout_in_minutes: 120		timeout_in_minutes: 120

- label: "MacOS x86_64"
command: "libcxx/utils/ci/run-buildbot generic-cxx20"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "macos"
arch: "x86_64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "MacOS arm64"
command: "libcxx/utils/ci/run-buildbot generic-cxx20"
artifact_paths:
- "**/test-results.xml"
- "*/.abilist"
agents:
queue: "libcxx-builders"
os: "macos"
arch: "arm64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Build with the configuration we use to generate libc++.dylib on Apple platforms
- label: "Apple system"
command: "libcxx/utils/ci/run-buildbot apple-system"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "macos"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

# Test back-deployment to older Apple platforms
- label: "Apple back-deployment macosx10.9"
command: "libcxx/utils/ci/run-buildbot apple-system-backdeployment-10.9"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "macos10.15" # TODO: For now, we're running the back-deployment tests for 10.9 on 10.15, because we don't have proper 10.9 machines
arch: "x86_64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Apple back-deployment macosx10.15"
command: "libcxx/utils/ci/run-buildbot apple-system-backdeployment-10.15"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "macos10.15"
arch: "x86_64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "AArch64"
command: "libcxx/utils/ci/run-buildbot aarch64"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "aarch64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "AArch64 -fno-exceptions"
command: "libcxx/utils/ci/run-buildbot aarch64-noexceptions"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "aarch64"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Armv8"
command: "libcxx/utils/ci/run-buildbot armv8"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Armv8 -fno-exceptions"
command: "libcxx/utils/ci/run-buildbot armv8-noexceptions"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Armv7"
command: "libcxx/utils/ci/run-buildbot armv7"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l" # Compiling for v7, running on v8 hardware
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Armv7 -fno-exceptions"
command: "libcxx/utils/ci/run-buildbot armv7-noexceptions"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders-linaro-arm"
arch: "armv8l" # Compiling for v7, running on v8 hardware
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "AIX (32-bit)"
command: "libcxx/utils/ci/run-buildbot aix"
artifact_paths:
- "**/test-results.xml"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
env:
OBJECT_MODE: "32"
agents:
queue: libcxx-builders
os: aix
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "AIX (64-bit)"
command: "libcxx/utils/ci/run-buildbot aix"
artifact_paths:
- "**/test-results.xml"
env:
OBJECT_MODE: "64"
agents:
queue: libcxx-builders
os: aix
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120