This is an archive of the discontinued LLVM Phabricator instance.

Add BOLT builder and worker configurations
ClosedPublic

Authored by Amir on Dec 20 2021, 3:53 PM.

Details

Summary

Worker runs on a Meta-managed buildbot. Builder uses BOLTBuilder defined in D116060.
The configuration is tested with a temporary build master, which points to the current BOLT repo instead of the monorepo.

This diff is a part of BOLT upstreaming:
https://lists.llvm.org/pipermail/llvm-dev/2021-December/154290.html

Will only be pushed once BOLT is in monorepo.

Diff Detail

Event Timeline

Amir requested review of this revision.Dec 20 2021, 3:53 PM
Amir created this revision.
gkistanova accepted this revision.Dec 30 2021, 12:41 PM

Looks good with one cosmetic nit pick.

'-DLLVM_TARGETS_TO_BUILD=X86;AArch64',
"-DCMAKE_C_COMPILER_LAUNCHER=ccache",

Could you be consistent with the quotation marks, please?

With this fixed, please feel free to commit once D116060 is in.

This revision is now accepted and ready to land.Dec 30 2021, 12:41 PM
mehdi_amini added inline comments.Dec 30 2021, 1:34 PM
buildbot/osuosl/master/config/builders.py
2276

Nit: there is an option for ccache: -DLLVM_CCACHE_BUILD=ON

Amir updated this revision to Diff 396757.Dec 30 2021, 10:50 PM

Address review comments: uniform quotation, ccache option

Amir updated this revision to Diff 396758.Dec 30 2021, 10:52 PM

Remove contents of D116060 that was accidentally added to this diff

Amir marked an inline comment as done.Dec 30 2021, 10:53 PM
Amir added a comment.Dec 30 2021, 10:55 PM
This comment was removed by Amir.
Amir updated this revision to Diff 397969.Jan 6 2022, 12:54 PM

Rename worker, specify jobs and max_builds

Amir added a comment.Jan 11 2022, 9:31 PM

@gkistanova,

BOLT is now merged and ready to be built: https://github.com/llvm/llvm-project/commit/4c106cfdf7cf7eec861ad3983a3dd9a9e8f3a8ae
This diff is ready to be merged to enable BOLT buildbot.
I've sent you access credentials for bolt-worker, did you have a chance to add them to buildbot-master?

This revision was automatically updated to reflect the committed changes.

Hi Amir,

Please feel free to connect your worker to the staging buildbot.

Amir added a comment.Jan 12 2022, 8:13 AM

Hi Galina!

The worker is now connected to the staging buildmaster and successfully completed the first build.

Thanks for helping us set up the buildbot!

You are welcome, Amir!

Now let's wait for enough commits and builds to demonstrate the reliability of the bot. :)