This is an archive of the discontinued LLVM Phabricator instance.

Differential D115447

[PATCH] ASAN: Align declaration with definition of a fn
ClosedPublic

Authored by marxin on Dec 9 2021, 7:15 AM.

Details

Reviewers
vitalybuka
Commits
rG78f7a6fbe5bb: [PATCH] ASAN: Align declaration with definition of a fn
Summary

Fixes:
https://bugs.llvm.org/show_bug.cgi?id=51641

Diff Detail

Event Timeline

marxin requested review of this revision.Dec 9 2021, 7:15 AM
marxin created this revision.
marxin added a reviewer: vitalybuka.
Harbormaster completed remote builds in B138446: Diff 393158.Dec 9 2021, 8:14 AM
vitalybuka accepted this revision.Dec 9 2021, 12:24 PM
This revision is now accepted and ready to land.Dec 9 2021, 12:24 PM
Closed by commit rG78f7a6fbe5bb: [PATCH] ASAN: Align declaration with definition of a fn (authored by marxin, committed by vitalybuka). · Explain WhyFeb 23 2022, 11:28 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG78f7a6fbe5bb: [PATCH] ASAN: Align declaration with definition of a fn.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2022, 11:28 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
lib/
asan/
2 lines

Diff 410883

compiler-rt/lib/asan/asan_errors.h

Show First 20 Lines • Show All 366 Lines • ▼ Show 20 Linesstruct ErrorGeneric : ErrorBase {
AddressDescription addr_description; AddressDescription addr_description;
uptr pc, bp, sp; uptr pc, bp, sp;
uptr access_size; uptr access_size;
const char *bug_descr; const char *bug_descr;
bool is_write; bool is_write;
u8 shadow_val; u8 shadow_val;
ErrorGeneric() = default; // (*) ErrorGeneric() = default; // (*)
ErrorGeneric(u32 tid, uptr addr, uptr pc_, uptr bp_, uptr sp_, bool is_write_, ErrorGeneric(u32 tid, uptr pc_, uptr bp_, uptr sp_, uptr addr, bool is_write_,
uptr access_size_); uptr access_size_);
void Print(); void Print();
}; };
// clang-format off // clang-format off
#define ASAN_FOR_EACH_ERROR_KIND(macro) \ #define ASAN_FOR_EACH_ERROR_KIND(macro) \
macro(DeadlySignal) \ macro(DeadlySignal) \
macro(DoubleFree) \ macro(DoubleFree) \
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines