KaleidoscopeJIT example code dangling std::unique_ptr issue

[7mile]

Summary

In the example code for Chapter 4, we found:

cpp
// EPC: Expected<std::unique_ptr<...>>
auto EPC = SelfExecutorProcessControl::Create();
// ...
auto ES = std::make_unique<ExecutionSession>(std::move(*EPC)); // EPC is moved here
// ...
JITTargetMachineBuilder JTMB((*EPC)->getTargetTriple()); // invalid access

But in KaleidoscopeJIT Chapter 1,2,3 and the include file outside the chapter, this part is

cpp
JITTargetMachineBuilder JTMB(
        ES->getExecutorProcessControl().getTargetTriple()); // access from the owner

[lhames]

Thanks 7mile!

Do you have commit access? If not, please let me know what name and email you would like me to use for attribution and I can commit on your behalf.

[7mile]

In D115260#3194015, @lhames wrote:

Thanks 7mile!

Do you have commit access? If not, please let me know what name and email you would like me to use for attribution and I can commit on your behalf.

OK~

seven-mile
[e-mail]

llvm/examples/Kaleidoscope/BuildingAJIT/Chapter4/KaleidoscopeJIT.h

if (!EPCIU)
       return EPCIU.takeError();
 
     (*EPCIU)->createLazyCallThroughManager(
         *ES, pointerToJITTargetAddress(&handleLazyCallThroughError));
 
     if (auto Err = setUpInProcessLCTMReentryViaEPCIU(**EPCIU))
       return std::move(Err);
 
-    JITTargetMachineBuilder JTMB((*EPC)->getTargetTriple());
+    JITTargetMachineBuilder JTMB(
+        ES->getExecutorProcessControl().getTargetTriple());
 
     auto DL = JTMB.getDefaultDataLayoutForTarget();
     if (!DL)
       return DL.takeError();
 
     return std::make_unique<KaleidoscopeJIT>(std::move(ES), std::move(*EPCIU),
                                              std::move(JTMB), std::move(*DL));
   }