This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Fix atomic test for _BitInt
ClosedPublic

Authored by ldionne on Dec 6 2021, 3:16 PM.

Details

Reviewers
aaron.ballman
Group Reviewers
Restricted Project
Commits
rGc49a13a45a0f: [libc++] Fix atomic test for _BitInt
Summary

In 6c75ab5f66b4, Clang deprecated _ExtInt in favor of _BitInt, which
made this test fail. This patch disables the test on older compilers
and uses the new _BitInt type instead.

Diff Detail

Event Timeline

ldionne requested review of this revision.Dec 6 2021, 3:16 PM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 3:16 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
aaron.ballman accepted this revision.Dec 6 2021, 3:24 PM

LGTM! Thanks for catching this!

ldionne updated this revision to Diff 392263.Dec 6 2021, 7:26 PM

Try to fix CI

I've verified this patch solves problems we see in our downstream CI with
https://reviews.llvm.org/rG6c75ab5f66b403f7ca67e86aeed3a58abe10570b

Please submit :)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2021, 4:30 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.