This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Move tsan/rtl build rules into tsan/rtl/CMakeLists.txt
ClosedPublic

Authored by thakis on Dec 6 2021, 6:55 AM.

Details

Summary

That way, the build rules are closer to the source files they describe.

No intended behavior change.

Diff Detail

Event Timeline

thakis created this revision.Dec 6 2021, 6:55 AM
thakis requested review of this revision.Dec 6 2021, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 6:55 AM
thakis added inline comments.Dec 6 2021, 6:57 AM
compiler-rt/lib/tsan/rtl/CMakeLists.txt
1

This file is identical to what I removed from the other file, except:

  • this line grew and additional ../
20
  • the source list lost the leading rtl/ on all lines
159
  • All the go rules grew an /.. after ${CMAKE_CURRENT_SOURCE_DIR}

(kind of feels the go rules should be in tsan/go/CMakeLists.txt maybe)

162
  • (i removed a trailing space on this line and on the same line a bit below)
dvyukov accepted this revision.Dec 6 2021, 7:22 AM
This revision is now accepted and ready to land.Dec 6 2021, 7:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 4:59 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript