This is an archive of the discontinued LLVM Phabricator instance.

Differential D115147

clang-format: [JS] test case for numeric separators.
ClosedPublic

Authored by mprobst on Dec 6 2021, 5:18 AM.

Details

Reviewers
krasimir
MyDeveloperDay
Commits
rG327d966365d7: clang-format: [JS] test case for numeric separators.
Summary

ES2021 allows numeric literals using _ as a separator. This already
works, but had no test.

Diff Detail

Event Timeline

mprobst requested review of this revision.Dec 6 2021, 5:18 AM
mprobst created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 5:18 AM
Harbormaster completed remote builds in B137636: Diff 392030.Dec 6 2021, 5:49 AM
MyDeveloperDay accepted this revision.Dec 6 2021, 6:19 AM
MyDeveloperDay added a subscriber: MyDeveloperDay.

LGTM

This revision is now accepted and ready to land.Dec 6 2021, 6:19 AM
MyDeveloperDay added a project: Restricted Project.Dec 6 2021, 6:19 AM
Closed by commit rG327d966365d7: clang-format: [JS] test case for numeric separators. (authored by mprobst). · Explain WhyDec 6 2021, 10:01 AM
This revision was automatically updated to reflect the committed changes.
mprobst added a commit: rG327d966365d7: clang-format: [JS] test case for numeric separators..

Revision Contents

PathSize
clang/
unittests/
Format/
4 lines

Diff 392118

clang/unittests/Format/FormatTestJS.cpp

Show First 20 Lines • Show All 2,686 Lines • ▼ Show 20 Lines verifyFormat(
"}\n", "}\n",
"interface Assertable<State extends {}> {\n" "interface Assertable<State extends {}> {\n"
" assert<ExportedState extends {}, DependencyState extends State = " " assert<ExportedState extends {}, DependencyState extends State = "
"State>(callback: Callback<ExportedState, DependencyState>): asserts " "State>(callback: Callback<ExportedState, DependencyState>): asserts "
"this is ExtendedState<DependencyState&ExportedState>;\n" "this is ExtendedState<DependencyState&ExportedState>;\n"
"}\n"); "}\n");
} }
TEST_F(FormatTestJS, NumericSeparators) {
verifyFormat("x = 1_000_000 + 12;", "x = 1_000_000 + 12;");
}
} // namespace format } // namespace format
} // end namespace clang } // end namespace clang