Page MenuHomePhabricator

Fix error reporting for "process load" and add a test for it.
ClosedPublic

Authored by jingham on Dec 2 2021, 6:13 PM.

Details

Summary

We weren't reporting errors (like file not found) from "process load", because when you just passed one string and no paths, the utility function didn't actually gather the error. Fix that and add a test.

The only weak part of the patch is that the error string comes from the platform plugin so I don't actually know what it is going to look like. So I tested that we don't produce the "unknown error" string instead. That's not really API, it's just what the only current implementation produces when it couldn't get the error. If we get a second implementation, we'll either just ensure it produces the same string or extract that somewhere and set it as the generic error. But that seemed overkill for this patch.

Diff Detail

Event Timeline

jingham created this revision.Dec 2 2021, 6:13 PM
jingham requested review of this revision.Dec 2 2021, 6:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2021, 6:13 PM
This revision is now accepted and ready to land.Dec 3 2021, 9:09 AM