This is an archive of the discontinued LLVM Phabricator instance.

libcxx pretty printers: remove non-lazy_string fallback
ClosedPublic

Authored by dblaikie on Dec 2 2021, 12:18 PM.

Reviewers

None

Group Reviewers

Restricted Project

Commits

Summary

This has been supported on gdb for something like ~10 years, so doesn't
seem necessary to carry a fallback.

This revision was not accepted when it landed; it landed in state Draft.Dec 2 2021, 2:31 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: Restricted Project. · View Herald Transcript

Path

Size

libcxx/

utils/

gdb/

libcxx/

4 lines

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines	def to_string(self):
is_long = short_size & short_mask		is_long = short_size & short_mask
if is_long:		if is_long:
long_field = value_field["__l"]		long_field = value_field["__l"]
data = long_field["__data_"]		data = long_field["__data_"]
size = long_field["__size_"]		size = long_field["__size_"]
else:		else:
data = short_field["__data_"]		data = short_field["__data_"]
size = self._get_short_size(short_field, short_size)		size = self._get_short_size(short_field, short_size)
if hasattr(data, "lazy_string"):
return data.lazy_string(length=size)		return data.lazy_string(length=size)
return data.string(length=size)

def display_hint(self):		def display_hint(self):
return "string"		return "string"


class StdStringViewPrinter(object):		class StdStringViewPrinter(object):
"""Print a std::string_view."""		"""Print a std::string_view."""

▲ Show 20 Lines • Show All 772 Lines • Show Last 20 Lines