Add jstopinfo support to llgs
ClosedPublic
Actions

Authored by labath on Jul 22 2015, 7:11 AM.

Details

Reviewers

ovyalov
clayborg

Commits

rLLDB242997: Add jstopinfo support to llgs
rL242997: Add jstopinfo support to llgs
rG05569f679a13: Add jstopinfo support to llgs

Summary

This adds support for jstopinfo field of stop-reply packets. This field enables us to avoid
querying full thread stop data on most stops (see r242593 for more details).

Diff Detail

Repository: rL LLVM

Event Timeline

labath updated this revision to Diff 30348.Jul 22 2015, 7:11 AM

labath retitled this revision from to Add jstopinfo support to llgs.

labath updated this object.

labath added reviewers: ovyalov, clayborg.

labath added a subscriber: lldb-commits.

Looks good.

This revision is now accepted and ready to land.Jul 22 2015, 10:31 AM

ovyalov accepted this revision.Jul 22 2015, 10:59 AM

ovyalov edited edge metadata.

ovyalov added inline comments.

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
720 ↗	(On Diff #30348)	Nit: if (thread_index > 0)? In this case no to acquire NativeProcessProtocol::m_threads_mutex
723 ↗	(On Diff #30348)	Could you check for threads_info_sp != nullptr?

Closed by commit rL242997: Add jstopinfo support to llgs (authored by labath). · Explain WhyJul 23 2015, 2:10 AM

This revision was automatically updated to reflect the committed changes.

labath marked 2 inline comments as done.

Revision Contents
Changeset List

			Path	Packages
M			lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp (2 lines)
M			lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.h (5 lines)
M			lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp (6 lines)
M			lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp (177 lines)