This is an archive of the discontinued LLVM Phabricator instance.

Differential D113870

[DebugInfo] Fix Test Targets in D108261
ClosedPublic

Authored by kyulee on Nov 14 2021, 8:56 PM.

Details

Reviewers
dblaikie
ellis
Commits
rG0d1d05854444: [DebugInfo] Fix Test Targets in D108261
Summary

It appears REQUIRES are needed for tests added in D108261.
This was not caught in the pre-merge tests but in the post-commit tests.
The fix is to move the tests into the target sub-directories.

Diff Detail

Event Timeline

kyulee requested review of this revision.Nov 14 2021, 8:56 PM
kyulee created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2021, 8:56 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kyulee added reviewers: dblaikie, ellis.Nov 14 2021, 8:59 PM
dblaikie accepted this revision.Nov 14 2021, 9:25 PM

Please move the tests into the relevant subdirectories that implicitly require the relevant target, rather than adding individual REQUIRES clauses.

llvm/test/DebugInfo/X86/debugline-endsequence.s
3

This test could be moved into the llvm/test/DebugInfo/X86 directory instead, which implies that requires clause for all tests there.

The other test can go in llvm/test/DebugInfo/AArch64.

This revision is now accepted and ready to land.Nov 14 2021, 9:25 PM
kyulee updated this revision to Diff 387155.Nov 14 2021, 9:30 PM

Move tests into sub-directories

kyulee retitled this revision from Fix missing REQURIES for Tests in D108261 to [DebugInfo] Fix Test Targets in D108261.Nov 14 2021, 9:35 PM
kyulee edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Nov 14 2021, 9:36 PM
Closed by commit rG0d1d05854444: [DebugInfo] Fix Test Targets in D108261 (authored by kyulee). · Explain Why
This revision was automatically updated to reflect the committed changes.
kyulee added a commit: rG0d1d05854444: [DebugInfo] Fix Test Targets in D108261.
kyulee edited the summary of this revision. (Show Details)Nov 14 2021, 9:38 PM
Harbormaster completed remote builds in B134190: Diff 387155.Nov 14 2021, 10:03 PM

Revision Contents

Diff 387156

llvm/test/DebugInfo/AArch64/debugline-endsequence.ll

  • This file was moved from llvm/test/DebugInfo/debugline-endsequence.ll.
The contents of this file were not changed.

llvm/test/DebugInfo/X86/debugline-endsequence.s

  • This file was moved from llvm/test/DebugInfo/debugline-endsequence.s.

llvm/test/DebugInfo/debugline-endsequence.ll

  • This file was moved to llvm/test/DebugInfo/AArch64/debugline-endsequence.ll.

llvm/test/DebugInfo/debugline-endsequence.s

  • This file was moved to llvm/test/DebugInfo/X86/debugline-endsequence.s.