This is an archive of the discontinued LLVM Phabricator instance.

Differential D113598

[debugserver] Remove unused variable
ClosedPublic

Authored by JDevlieghere on Nov 10 2021, 11:26 AM.

Details

Reviewers
jasonmolenda
Commits
rG18d883cc0a06: [debugserver] Remove varaible `ldb_set` which is set but not used.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Nov 10 2021, 11:26 AM
JDevlieghere created this revision.
jasonmolenda accepted this revision.Nov 10 2021, 11:26 AM

LGTM

This revision is now accepted and ready to land.Nov 10 2021, 11:26 AM
Harbormaster completed remote builds in B133550: Diff 386261.Nov 10 2021, 11:29 AM
Closed by commit rG18d883cc0a06: [debugserver] Remove varaible `ldb_set` which is set but not used. (authored by JDevlieghere). · Explain WhyNov 10 2021, 11:57 AM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG18d883cc0a06: [debugserver] Remove varaible `ldb_set` which is set but not used..
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 11:57 AM

Revision Contents

PathSize
lldb/
tools/
debugserver/
source/
3 lines

Diff 386261

lldb/tools/debugserver/source/RNBRemote.cpp

Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
const register_map_entry_t &reg) { const register_map_entry_t &reg) {
const char *default_lldb_encoding = "uint"; const char *default_lldb_encoding = "uint";
const char *lldb_encoding = default_lldb_encoding; const char *lldb_encoding = default_lldb_encoding;
const char *gdb_group = "general"; const char *gdb_group = "general";
const char *default_gdb_type = "int"; const char *default_gdb_type = "int";
const char *gdb_type = default_gdb_type; const char *gdb_type = default_gdb_type;
const char *default_lldb_format = "hex"; const char *default_lldb_format = "hex";
const char *lldb_format = default_lldb_format; const char *lldb_format = default_lldb_format;
const char *lldb_set = NULL;
switch (reg.nub_info.type) { switch (reg.nub_info.type) {
case Uint: case Uint:
lldb_encoding = "uint"; lldb_encoding = "uint";
break; break;
case Sint: case Sint:
lldb_encoding = "sint"; lldb_encoding = "sint";
break; break;
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
gdb_type = "float"; gdb_type = "float";
lldb_format = "vector-float32"; lldb_format = "vector-float32";
break; break;
case VectorOfUInt128: case VectorOfUInt128:
gdb_type = "float"; gdb_type = "float";
lldb_format = "vector-uint128"; lldb_format = "vector-uint128";
break; break;
}; };
if (reg_set_info && reg.nub_info.set < num_reg_sets)
lldb_set = reg_set_info[reg.nub_info.set].name;
uint32_t indent = 2; uint32_t indent = 2;
XMLElementStart(s, indent, "reg", true); XMLElementStart(s, indent, "reg", true);
XMLAttributeString(s, "name", reg.nub_info.name); XMLAttributeString(s, "name", reg.nub_info.name);
XMLAttributeUnsignedDecimal(s, "regnum", reg_num); XMLAttributeUnsignedDecimal(s, "regnum", reg_num);
XMLAttributeUnsignedDecimal(s, "offset", reg.offset); XMLAttributeUnsignedDecimal(s, "offset", reg.offset);
XMLAttributeUnsignedDecimal(s, "bitsize", reg.nub_info.size * 8); XMLAttributeUnsignedDecimal(s, "bitsize", reg.nub_info.size * 8);
▲ Show 20 Lines • Show All 991 Lines • Show Last 20 Lines