This is an archive of the discontinued LLVM Phabricator instance.

Fix FileSpec::IsSymlink implementation.
ClosedPublic

Authored by ovyalov on Jul 20 2015, 9:14 AM.

Details

Reviewers
amccarth
clayborg
Summary

stat call returns information about target file in case of symbolic link.
In order to query symlink status we can use lstat on POSIX systems and GetFileAttributes on Windows.

Diff Detail

Event Timeline

ovyalov updated this revision to Diff 30162.Jul 20 2015, 9:14 AM
ovyalov retitled this revision from to Fix FileSpec::IsSymlink implementation..
ovyalov updated this object.
ovyalov added reviewers: clayborg, amccarth.
ovyalov added a subscriber: lldb-commits.
amccarth accepted this revision.Jul 20 2015, 10:47 AM
amccarth edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jul 20 2015, 10:47 AM
clayborg accepted this revision.Jul 20 2015, 3:16 PM
clayborg edited edge metadata.

Looks good.

ovyalov closed this revision.Jul 20 2015, 6:30 PM

Files:

/lldb/trunk/include/lldb/Host/FileSpec.h
/lldb/trunk/source/Host/common/FileSpec.cpp

Users:

ovyalov (Author)

http://reviews.llvm.org/rL242753