Page MenuHomePhabricator

[extract_symbols.py] Fix llvm-readobj options.
ClosedPublic

Authored by simon_tatham on Nov 10 2021, 3:41 AM.

Details

Summary

As of D105532, a couple of llvm-readobj options have slightly changed
their spellings. '-file-headers' has become '--file-header', and
'-symbols' has become '--symbols'. A modern llvm-readobj will respond
to those single-dash spellings by trying to parse them as combinations
of single-letter options, so that you get "unknown argument '-f'" for
-file-headers, and "unknown argument '-y'" for the second letter of
-symbols.

extract_symbols.py was still invoking llvm-readobj with those old
single-dash spellings. Changed them to the newly canonical ones, which
as far as I can tell still work on llvm-readobj from before the
change.

Diff Detail

Event Timeline

simon_tatham requested review of this revision.Nov 10 2021, 3:41 AM
simon_tatham created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2021, 3:41 AM
MaskRay accepted this revision.Nov 10 2021, 10:30 AM

Looks great!

This revision is now accepted and ready to land.Nov 10 2021, 10:30 AM
This revision was automatically updated to reflect the committed changes.