This is an archive of the discontinued LLVM Phabricator instance.

[libc++][cmake] Improves benchmark build.
ClosedPublic

Authored by Mordante on Nov 8 2021, 10:02 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG3ca520f19f43: [libc++][cmake] Improves benchmark build.
Summary

The CMake dependencies don't properly list the libc++ headers. When a
libc++ header is modified the affected benchmarks aren't rebuild. This
makes testing benchmarks tricky and may cause accidentally not using the
latest modifications during testing. This change causes CMake to
determine the proper dependencies.

This shouldn't affect the CI build.

Diff Detail

Event Timeline

Mordante created this revision.Nov 8 2021, 10:02 AM
Mordante requested review of this revision.Nov 8 2021, 10:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2021, 10:02 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Nov 8 2021, 1:06 PM
This revision is now accepted and ready to land.Nov 8 2021, 1:06 PM
This revision was automatically updated to reflect the committed changes.