[lldb] Use std::string instead of llvm::Twine

[JDevlieghere]

Summary

From the documentation:

A Twine is not intended for use directly and should not be stored, its implementation relies on the ability to store pointers to temporary stack objects which may be deallocated at the end of a statement. Twines should only be used accepted as const references in arguments, when an API wishes to accept possibly-concatenated strings.

rdar://84799118

[dblaikie]

Looks good to me.

Alternatively the string concatenation could be inlined, then the Twine usage would be correct - but would still need an explicit "str()", like this:

SendPacketAndWaitForResponse(("QEnableCompression:type:" + avail_name + ";").str(), response)

Which may or may not be marginally faster because the Twine could cheaply compute the total length of the required buffer/presize the string... maybe.

[mgorny]

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

1113

I'd personally prefer avail_name.str() instead of explicit std::string() but that's just me.

[JDevlieghere]

@david: Yes, I considered it, but I think this is slightly more readable.

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

1113

Works for me. That actually makes it fit on a single line.

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

for (auto compression : supported_compressions) {
         break;
       }
     }
   }
 #endif
 
   if (avail_type != CompressionType::None) {
     StringExtractorGDBRemote response;
-    llvm::Twine packet = "QEnableCompression:type:" + avail_name + ";";
-    if (SendPacketAndWaitForResponse(packet.str(), response) !=
-        PacketResult::Success)
+    std::string packet = "QEnableCompression:type:" + avail_name.str() + ";";
+    if (SendPacketAndWaitForResponse(packet, response) != PacketResult::Success)
       return;
 
     if (response.IsOKResponse()) {
       m_compression_type = avail_type;
     }
   }
 }