This is an archive of the discontinued LLVM Phabricator instance.

Differential D113292

[PATCH] sanitizer: Fix -Wpedantic GCC warning
ClosedPublic

Authored by marxin on Nov 5 2021, 9:06 AM.

Details

Reviewers
vitalybuka
Commits
rG78d3e0a4f140: sanitizer: Fix -Wpedantic GCC warning
Summary

Fixes:
sanitizer_stacktrace.h:212:5: warning: ISO C++ forbids braced-groups within expressions [-Wpedantic]

Diff Detail

Event Timeline

marxin requested review of this revision.Nov 5 2021, 9:06 AM
marxin created this revision.
Harbormaster completed remote builds in B132705: Diff 385095.Nov 5 2021, 9:22 AM
vitalybuka accepted this revision.Nov 5 2021, 10:00 AM
This revision is now accepted and ready to land.Nov 5 2021, 10:00 AM
Closed by commit rG78d3e0a4f140: sanitizer: Fix -Wpedantic GCC warning (authored by marxin). · Explain WhyNov 5 2021, 10:06 AM
This revision was automatically updated to reflect the committed changes.
marxin added a commit: rG78d3e0a4f140: sanitizer: Fix -Wpedantic GCC warning.
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2021, 10:06 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
4 lines

Diff 385095

compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.h

Show First 20 Lines • Show All 203 Lines • ▼ Show 20 Lines
// It needs to be a macro because otherwise we will get the name // It needs to be a macro because otherwise we will get the name
// of this function on the top of most stacks. Attribute artificial // of this function on the top of most stacks. Attribute artificial
// does not do what it claims to do, unfortunatley. And attribute // does not do what it claims to do, unfortunatley. And attribute
// __nodebug__ is clang-only. If we would have an attribute that // __nodebug__ is clang-only. If we would have an attribute that
// would remove this function from debug info, we could simply make // would remove this function from debug info, we could simply make
// StackTrace::GetCurrentPc() faster. // StackTrace::GetCurrentPc() faster.
#if defined(__x86_64__) #if defined(__x86_64__)
# define GET_CURRENT_PC() \ # define GET_CURRENT_PC() \
({ \ (__extension__({ \
uptr pc; \ uptr pc; \
asm("lea 0(%%rip), %0" : "=r"(pc)); \ asm("lea 0(%%rip), %0" : "=r"(pc)); \
pc; \ pc; \
}) }))
#else #else
# define GET_CURRENT_PC() StackTrace::GetCurrentPc() # define GET_CURRENT_PC() StackTrace::GetCurrentPc()
#endif #endif
#endif // SANITIZER_STACKTRACE_H #endif // SANITIZER_STACKTRACE_H