This is an archive of the discontinued LLVM Phabricator instance.

Differential D113060

[ASan] Turned on callback optimization on by default.
AbandonedPublic

Authored by kstoimenov on Nov 2 2021, 2:47 PM.

Details

Reviewers
None
Summary

This will only affect projects, which use callbacks for code instrumentation.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 debian > Clang.CodeGen::asan-use-callbacks.cpp
90 msx64 debian > LLVM.Instrumentation/AddressSanitizer::asan-masked-load-store.ll
30 msx64 debian > LLVM.Instrumentation/AddressSanitizer::experiment-call.ll
30 msx64 debian > LLVM.Instrumentation/AddressSanitizer::instrumentation-with-call-threshold.ll
60 msx64 debian > LLVM.Instrumentation/HWAddressSanitizer::kernel-inline.ll

Event Timeline

kstoimenov created this revision.Nov 2 2021, 2:47 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptNov 2 2021, 2:47 PM
kstoimenov requested review of this revision.Nov 2 2021, 2:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 2:47 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kstoimenov updated this revision to Diff 384258.Nov 2 2021, 3:14 PM

Removed some debug printfs.

Harbormaster completed remote builds in B132087: Diff 384258.Nov 2 2021, 3:42 PM
kstoimenov abandoned this revision.Dec 8 2021, 10:45 AM

Revision Contents

PathSize
llvm/
lib/
Transforms/
Instrumentation/
2 lines

Diff 384258

llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp

Show First 20 Lines • Show All 359 Lines • ▼ Show 20 Lines
// Optimization flags. Not user visible, used mostly for testing // Optimization flags. Not user visible, used mostly for testing
// and benchmarking the tool. // and benchmarking the tool.
static cl::opt<bool> ClOpt("asan-opt", cl::desc("Optimize instrumentation"), static cl::opt<bool> ClOpt("asan-opt", cl::desc("Optimize instrumentation"),
cl::Hidden, cl::init(true)); cl::Hidden, cl::init(true));
static cl::opt<bool> ClOptimizeCallbacks("asan-optimize-callbacks", static cl::opt<bool> ClOptimizeCallbacks("asan-optimize-callbacks",
cl::desc("Optimize callbacks"), cl::desc("Optimize callbacks"),
cl::Hidden, cl::init(false)); cl::Hidden, cl::init(true));
static cl::opt<bool> ClOptSameTemp( static cl::opt<bool> ClOptSameTemp(
"asan-opt-same-temp", cl::desc("Instrument the same temp just once"), "asan-opt-same-temp", cl::desc("Instrument the same temp just once"),
cl::Hidden, cl::init(true)); cl::Hidden, cl::init(true));
static cl::opt<bool> ClOptGlobals("asan-opt-globals", static cl::opt<bool> ClOptGlobals("asan-opt-globals",
cl::desc("Don't instrument scalar globals"), cl::desc("Don't instrument scalar globals"),
cl::Hidden, cl::init(true)); cl::Hidden, cl::init(true));
▲ Show 20 Lines • Show All 3,312 Lines • Show Last 20 Lines