This is an archive of the discontinued LLVM Phabricator instance.

Differential D112728

[libc++] Update clang-format to C++20.
ClosedPublic

Authored by Mordante on Oct 28 2021, 8:51 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG4cb3d7d7b4ab: [libc++] Update clang-format to C++20.
Summary

We now use clang-format-13 which has the option SpacesInAngles. This
allows us to switch the default language version to C++20, which should
avoid breaking code when formatting due to the adding of whitespace.
For example u8"foo" no longer is formatted as u8 "foo".

Diff Detail

Unit TestsFailed

TimeTest
3,880 mslibcxx CI GCC 11 / C++latest > llvm-libc++-shared-gcc-cfg-in.std/utilities/format/format_formatter/format_context/format_context::ctor.pass.cpp
4,130 mslibcxx CI GCC 11 / C++latest > llvm-libc++-shared-gcc-cfg-in.std/utilities/format/format_formatter/format_context/format_context::locale.pass.cpp
2,830 mslibcxx CI GCC 11 / C++latest > llvm-libc++-shared-gcc-cfg-in.std/utilities/format/format_functions::locale-specific_form.pass.cpp

Event Timeline

Mordante requested review of this revision.Oct 28 2021, 8:51 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 8:51 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B131215: Diff 383052.Oct 28 2021, 9:09 AM
ldionne accepted this revision.Oct 28 2021, 9:36 AM
This revision is now accepted and ready to land.Oct 28 2021, 9:36 AM
This revision was landed with ongoing or failed builds.Oct 30 2021, 3:51 AM
Closed by commit rG4cb3d7d7b4ab: [libc++] Update clang-format to C++20. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG4cb3d7d7b4ab: [libc++] Update clang-format to C++20..

Revision Contents

PathSize
libcxx/
3 lines

Diff 383052

libcxx/.clang-format

BasedOnStyle: LLVM BasedOnStyle: LLVM
--- ---
Language: Cpp Language: Cpp
Standard: Cpp03 Standard: c++20
SpacesInAngles: Leave
AlwaysBreakTemplateDeclarations: true AlwaysBreakTemplateDeclarations: true
PointerAlignment: Left PointerAlignment: Left
# Disable formatting options which may break tests. # Disable formatting options which may break tests.
SortIncludes: false SortIncludes: false
ReflowComments: false ReflowComments: false
# libc++'s preferred indentions of preprocessor statements. # libc++'s preferred indentions of preprocessor statements.
IndentPPDirectives: AfterHash IndentPPDirectives: AfterHash
# libc++ has some long names so we need more than the 80 column limit imposed by LLVM style, for sensible formatting # libc++ has some long names so we need more than the 80 column limit imposed by LLVM style, for sensible formatting
ColumnLimit: 120 ColumnLimit: 120
--- ---