This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove Clang-11 support.
ClosedPublic

Authored by Mordante on Oct 28 2021, 8:43 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG7ee5e7e97c1c: [libc++] Remove Clang-11 support.
Summary

Since we no longer officially support Clang 11 remove the work-arounds
for this version.

Diff Detail

Event Timeline

Mordante requested review of this revision.Oct 28 2021, 8:43 AM
Mordante created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 8:43 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Oct 28 2021, 8:50 AM
ldionne added a subscriber: ldionne.

LGTM!

Just FYI, to make sure you've removed all instances of Clang-11 related Lit features from the test suite, you can use this:

<build>/bin/llvm-lit libcxx/test libcxxabi/test --show-used-features

It will print a list of all the Lit features we mention in the test suite, and you can make sure that we don't mention clang-11 anymore after your patch. I guess grepping can also do the job, but sometimes it can be difficult to sort through the output if we mention clang-11 for things that are not Lit features. Anyway, just thought I'd let you know about this tool we have :-).

This revision is now accepted and ready to land.Oct 28 2021, 8:50 AM

LGTM!

Just FYI, to make sure you've removed all instances of Clang-11 related Lit features from the test suite, you can use this:

<build>/bin/llvm-lit libcxx/test libcxxabi/test --show-used-features

It will print a list of all the Lit features we mention in the test suite, and you can make sure that we don't mention clang-11 anymore after your patch. I guess grepping can also do the job, but sometimes it can be difficult to sort through the output if we mention clang-11 for things that are not Lit features. Anyway, just thought I'd let you know about this tool we have :-).

Thanks I wasn't aware of that tool! I just grepped for everything that remotely resembled clang 11 and the number of hits was very manageable :-)

Mordante updated this revision to Diff 383565.Oct 30 2021, 2:53 AM

Rebase to trigger CI.

This revision was automatically updated to reflect the committed changes.