This is an archive of the discontinued LLVM Phabricator instance.

Differential D112666

[NFC] Rewrite some tests.
AbandonedPublic

Authored by mnadeem on Oct 27 2021, 3:04 PM.

Details

Reviewers
None
Summary

just experimenting with phabricator

Diff Detail

Event Timeline

mnadeem requested review of this revision.Oct 27 2021, 3:04 PM
mnadeem created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2021, 3:04 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
mnadeem removed a project: Restricted Project.Oct 27 2021, 3:15 PM
mnadeem removed a subscriber: llvm-commits.
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2021, 3:15 PM
Harbormaster completed remote builds in B131051: Diff 382809.Oct 27 2021, 3:31 PM
mnadeem updated this revision to Diff 382832.Oct 27 2021, 4:03 PM
Harbormaster completed remote builds in B131066: Diff 382832.Oct 27 2021, 4:04 PM
mnadeem updated this revision to Diff 382835.Oct 27 2021, 4:07 PM
mnadeem added a child revision: D112675: [Instcombine] Add patterns to generate fneg(fabs(x)) instead of fcmp/sub/selects (part 1).Oct 27 2021, 4:15 PM
Harbormaster completed remote builds in B131067: Diff 382835.Oct 27 2021, 4:34 PM
mnadeem abandoned this revision.Jan 17 2023, 11:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 11:55 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
286 lines

Diff 382835

llvm/test/Transforms/InstCombine/fneg-fabs.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instcombine -S | FileCheck %s ; RUN: opt < %s -instcombine -S | FileCheck %s
; (X < +/-0.0) ? X : -X --> -fabs(X)
; (X <= +/-0.0) ? X : -X --> -fabs(X)
; One negative test with no fmf
define double @select_noFMF_nfabs_lt(double %x) {
; CHECK-LABEL: @select_noFMF_nfabs_lt(
; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]]
;
%cmp = fcmp olt double %x, 0.000000e+00
%negX = fneg double %x
%sel = select i1 %cmp, double %x, double %negX
ret double %sel
}
; One test where the neg has fmfs. ; ///////////////////////////////
define double @select_nsz_nfabs_lt_fmfProp(double %x) { ; (X < +/-0.0) ? X : (0.0 - X) --> (0.0 - fabs(X))
; CHECK-LABEL: @select_nsz_nfabs_lt_fmfProp( ; (X < +/-0.0) ? X : -X --> -X FMF on FNEG or on Select
; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00 ; ///////////////////////////////
; CHECK-NEXT: [[NEGX:%.*]] = fneg fast double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]]
;
%cmp = fcmp olt double %x, 0.000000e+00
%negX = fneg fast double %x
%sel = select nsz i1 %cmp, double %x, double %negX
ret double %sel
}
; Tests with various predicate types. ; (X < +/-0.0) ? X : (0.0 - X) --> (0.0 - fabs(X))
define double @select_nsz_nfabs_olt(double %x) { define double @olt_fsub(double %x) {
; CHECK-LABEL: @select_nsz_nfabs_olt( ; CHECK-LABEL: @olt_fsub(
; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fsub double 0.000000e+00, [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp olt double %x, 0.000000e+00 %cmp = fcmp olt double %x, 0.000000e+00
%negX = fneg double %x %negX = fsub double 0.000000e+00, %x
%sel = select nsz i1 %cmp, double %x, double %negX %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
define double @ult_fsub(double %x) {
define double @select_nsz_nfabs_ult(double %x) { ; CHECK-LABEL: @ult_fsub(
; CHECK-LABEL: @select_nsz_nfabs_ult(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fsub double 0.000000e+00, [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp ult double %x, 0.000000e+00 %cmp = fcmp ult double %x, 0.000000e+00
%negX = fneg double %x %negX = fsub double 0.000000e+00, %x
%sel = select nsz i1 %cmp, double %x, double %negX %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
define double @select_nsz_nfabs_ole(double %x) { ; Negative tests <= needs nsz on select.
; CHECK-LABEL: @select_nsz_nfabs_ole( define double @ole_fsub_nofmf(double %x) {
; CHECK-LABEL: @ole_fsub_nofmf(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ole double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp ole double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fsub double 0.000000e+00, [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp ole double %x, 0.000000e+00 %cmp = fcmp ole double %x, 0.000000e+00
%negX = fneg double %x %negX = fsub double 0.000000e+00, %x
%sel = select nsz i1 %cmp, double %x, double %negX %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
define double @ule_fsub_nofmf(double %x) {
define double @select_nsz_nfabs_ule(double %x) { ; CHECK-LABEL: @ule_fsub_nofmf(
; CHECK-LABEL: @select_nsz_nfabs_ule(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ule double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp ule double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fsub double 0.000000e+00, [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp ule double %x, 0.000000e+00 %cmp = fcmp ule double %x, 0.000000e+00
%negX = fneg double %x %negX = fsub double 0.000000e+00, %x
%sel = select nsz i1 %cmp, double %x, double %negX %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
; Negative tests <= needs nsz on select.
; (X > +/-0.0) ? -X : X --> -fabs(X) define double @ole_fneg_nofmf(double %x) {
; (X >= +/-0.0) ? -X : X --> -fabs(X) ; CHECK-LABEL: @ole_fneg_nofmf(
; One negative test with no fmf ; CHECK-NEXT: [[CMP:%.*]] = fcmp ole double [[X:%.*]], 0.000000e+00
define double @select_noFMF_nfabs_gt(double %x) {
; CHECK-LABEL: @select_noFMF_nfabs_gt(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select i1 [[CMP]], double [[NEGX]], double [[X]]
; CHECK-NEXT: ret double [[SEL]]
;
%cmp = fcmp ogt double %x, 0.000000e+00
%negX = fneg double %x
%sel = select i1 %cmp, double %negX, double %x
ret double %sel
}
; One test where the neg has fmfs.
define double @select_nsz_nfabs_gt_fmfProp(double %x) {
; CHECK-LABEL: @select_nsz_nfabs_gt_fmfProp(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg fast double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[NEGX]], double [[X]]
; CHECK-NEXT: ret double [[SEL]]
;
%cmp = fcmp ogt double %x, 0.000000e+00
%negX = fneg fast double %x
%sel = select nsz i1 %cmp, double %negX, double %x
ret double %sel
}
; Tests with various predicate types.
define double @select_nsz_nfabs_ogt(double %x) {
; CHECK-LABEL: @select_nsz_nfabs_ogt(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ogt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[NEGX]], double [[X]]
; CHECK-NEXT: ret double [[SEL]]
;
%cmp = fcmp ogt double %x, 0.000000e+00
%negX = fneg double %x
%sel = select nsz i1 %cmp, double %negX, double %x
ret double %sel
}
define double @select_nsz_nfabs_ugt(double %x) {
; CHECK-LABEL: @select_nsz_nfabs_ugt(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ugt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[NEGX]], double [[X]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp ugt double %x, 0.000000e+00 %cmp = fcmp ole double %x, 0.000000e+00
%negX = fneg double %x %negX = fneg double %x
%sel = select nsz i1 %cmp, double %negX, double %x %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
define double @ule_fneg_nofmf(double %x) {
define double @select_nsz_nfabs_oge(double %x) { ; CHECK-LABEL: @ule_fneg_nofmf(
; CHECK-LABEL: @select_nsz_nfabs_oge( ; CHECK-NEXT: [[CMP:%.*]] = fcmp ule double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[CMP:%.*]] = fcmp oge double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[NEGX]], double [[X]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp oge double %x, 0.000000e+00 %cmp = fcmp ule double %x, 0.000000e+00
%negX = fneg double %x %negX = fneg double %x
%sel = select nsz i1 %cmp, double %negX, double %x %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
define double @select_nsz_nfabs_uge(double %x) { ; One negative test "<" with no FMFs on FNeg or the select.
; CHECK-LABEL: @select_nsz_nfabs_uge( define double @fneg_nofmf(double %x) {
; CHECK-NEXT: [[CMP:%.*]] = fcmp uge double [[X:%.*]], 0.000000e+00 ; CHECK-LABEL: @fneg_nofmf(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[SEL:%.*]] = select nsz i1 [[CMP]], double [[NEGX]], double [[X]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[SEL]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp uge double %x, 0.000000e+00 %cmp = fcmp ult double %x, 0.000000e+00
%negX = fneg double %x %negX = fneg double %x
%sel = select nsz i1 %cmp, double %negX, double %x %retval = select i1 %cmp, double %x, double %negX
ret double %sel ret double %retval
} }
; (X < +/-0.0) ? X : (0.0 - X) --> (0.0 - fabs(X)) define double @ult_fneg1(double %x) {
; One negative test with <=. ; CHECK-LABEL: @ult_fneg1(
define double @select_noFMF_fsubfabs_le(double %x) { ; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00
; CHECK-LABEL: @select_noFMF_fsubfabs_le( ; CHECK-NEXT: [[NEGX:%.*]] = fneg nsz double [[X]]
; CHECK-NEXT: [[CMP:%.*]] = fcmp ole double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: [[SUB:%.*]] = fsub double 0.000000e+00, [[X]] ; CHECK-NEXT: ret double [[RETVAL]]
; CHECK-NEXT: [[RETVAL_0:%.*]] = select i1 [[CMP]], double [[X]], double [[SUB]]
; CHECK-NEXT: ret double [[RETVAL_0]]
;
%cmp = fcmp ole double %x, 0.000000e+00
%sub = fsub double 0.000000e+00, %x
%retval.0 = select i1 %cmp, double %x, double %sub
ret double %retval.0
}
define double @select_noFMF_fsubfabs_olt(double %x) {
; CHECK-LABEL: @select_noFMF_fsubfabs_olt(
; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[SUB:%.*]] = fsub double 0.000000e+00, [[X]]
; CHECK-NEXT: [[RETVAL_0:%.*]] = select i1 [[CMP]], double [[X]], double [[SUB]]
; CHECK-NEXT: ret double [[RETVAL_0]]
; ;
%cmp = fcmp olt double %x, 0.000000e+00 %cmp = fcmp ult double %x, 0.000000e+00
%sub = fsub double 0.000000e+00, %x %negX = fneg nsz double %x
%retval.0 = select i1 %cmp, double %x, double %sub %retval = select i1 %cmp, double %x, double %negX
ret double %retval.0 ret double %retval
} }
define double @ult_fneg2(double %x) {
define double @select_noFMF_fsubfabs_ult(double %x) { ; CHECK-LABEL: @ult_fneg2(
; CHECK-LABEL: @select_noFMF_fsubfabs_ult(
; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[SUB:%.*]] = fsub double 0.000000e+00, [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[RETVAL_0:%.*]] = select i1 [[CMP]], double [[X]], double [[SUB]] ; CHECK-NEXT: [[RETVAL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[RETVAL_0]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp ult double %x, 0.000000e+00 %cmp = fcmp ult double %x, 0.000000e+00
%sub = fsub double 0.000000e+00, %x %negX = fneg double %x
%retval.0 = select i1 %cmp, double %x, double %sub %retval = select nsz i1 %cmp, double %x, double %negX
ret double %retval.0 ret double %retval
} }
define double @olt_fneg1(double %x) {
; CHECK-LABEL: @olt_fneg1(
; With nsz:
; (X < +/-0.0) ? X : -X --> -fabs(X)
define double @select_nsz_fnegfabs_olt(double %x) {
; CHECK-LABEL: @select_nsz_fnegfabs_olt(
; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[NEGX:%.*]] = fneg nsz double [[X]] ; CHECK-NEXT: [[NEGX:%.*]] = fneg nsz double [[X]]
; CHECK-NEXT: [[RETVAL_0:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]] ; CHECK-NEXT: [[RETVAL:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: ret double [[RETVAL_0]] ; CHECK-NEXT: ret double [[RETVAL]]
; ;
%cmp = fcmp olt double %x, 0.000000e+00 %cmp = fcmp olt double %x, 0.000000e+00
%negX = fneg nsz double %x %negX = fneg nsz double %x
%retval.0 = select i1 %cmp, double %x, double %negX %retval = select i1 %cmp, double %x, double %negX
ret double %retval.0 ret double %retval
} }
define double @olt_fneg2(double %x) {
define double @select_nsz_fnegfabs_ult(double %x) { ; CHECK-LABEL: @olt_fneg2(
; CHECK-LABEL: @select_nsz_fnegfabs_ult( ; CHECK-NEXT: [[CMP:%.*]] = fcmp olt double [[X:%.*]], 0.000000e+00
; CHECK-NEXT: [[CMP:%.*]] = fcmp ult double [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: [[NEGX:%.*]] = fneg double [[X]]
; CHECK-NEXT: [[NEGX:%.*]] = fneg nsz double [[X]] ; CHECK-NEXT: [[RETVAL:%.*]] = select nsz i1 [[CMP]], double [[X]], double [[NEGX]]
; CHECK-NEXT: [[RETVAL_0:%.*]] = select i1 [[CMP]], double [[X]], double [[NEGX]] ; CHECK-NEXT: ret double [[RETVAL]]
; CHECK-NEXT: ret double [[RETVAL_0]]
; ;
%cmp = fcmp ult double %x, 0.000000e+00 %cmp = fcmp olt double %x, 0.000000e+00
%negX = fneg nsz double %x %negX = fneg double %x
%retval.0 = select i1 %cmp, double %x, double %negX %retval = select nsz i1 %cmp, double %x, double %negX
ret double %retval.0 ret double %retval
} }