This is an archive of the discontinued LLVM Phabricator instance.

tsan: don't use symbol binding 10
ClosedPublic

Authored by dvyukov on Oct 25 2021, 3:57 AM.

Details

Summary

Building Go programs with the current runtime fails with:

loadelf: race_linux_amd64: malformed elf file:
_ZZN6__tsan15RestoreAddrImpl5ApplyINS_11MappingGo48EEEmmE6ranges: invalid symbol binding 10

Go linker does not understand ELF in all its generality.
Don't use static const data in inline methods.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Oct 25 2021, 3:57 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 3:57 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Oct 25 2021, 4:03 AM
This revision is now accepted and ready to land.Oct 25 2021, 4:03 AM
This revision was automatically updated to reflect the committed changes.