This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Narrow down XFAILs regarding a MSVC mode specific bug to "windows-dll && msvc"
ClosedPublic

Authored by mstorsjo on Oct 22 2021, 2:51 PM.

Details

Summary

These tests don't fail when only windows-dll is set in mingw mode, as the
bug is specific to MSVC mode.

Split this one out from D112211, as this one is even clearer.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Oct 22 2021, 2:51 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2021, 2:51 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo updated this revision to Diff 381669.Oct 22 2021, 3:11 PM

Rebase and rerun CI

Ping - the referenced bug is specific to msvc mode, so the xfail only relates to that environment.

ldionne accepted this revision.Nov 5 2021, 12:33 PM

Oh yeah, that bug is on me :(

I hope I'll have time to investigate it eventually, but in case someone wants to look into it, I'd be happy to assist by reviewing or providing context about the attribute.

This revision is now accepted and ready to land.Nov 5 2021, 12:33 PM
This revision was landed with ongoing or failed builds.Nov 5 2021, 12:44 PM
This revision was automatically updated to reflect the committed changes.