[clang] fix typo correction not looking for candidates in base classes.

[mizvekov]

Summary

RecordMemberExprValidator was not looking through ElaboratedType
nodes when looking for candidates which occur in base classes.

Signed-off-by: Matheus Izvekov <[e-mail]>

[mizvekov]

.

clang/lib/Sema/SemaExprMember.cpp

bool ValidateCandidate(const TypoCorrection &candidate) override {
     // variables, or templates.
     if (!ND || !(isa<ValueDecl>(ND) || isa<FunctionTemplateDecl>(ND)))
       return false;
 
     // Accept candidates that occur in the current record.
     if (Record->containsDecl(ND))
       return true;
 
-    if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(Record)) {
+    if (const auto *RD = dyn_cast<CXXRecordDecl>(Record)) {
       // Accept candidates that occur in any of the current class' base classes.
       for (const auto &BS : RD->bases()) {
-        if (const RecordType *BSTy =
-                dyn_cast_or_null<RecordType>(BS.getType().getTypePtrOrNull())) {
+        if (const auto *BSTy = BS.getType()->getAs<RecordType>()) {
           if (BSTy->getDecl()->containsDecl(ND))
             return true;
         }
       }
     }
 
     return false;
   }

clang/test/CXX/drs/dr1xx.cpp

namespace dr140 { // dr140: yes
   void f(int *const) {} // expected-note {{previous}}
   void f(int[3]) {} // expected-error {{redefinition}}
   void g(const int);
   void g(int n) { n = 2; }
 }
 
 namespace dr141 { // dr141: yes
   template<typename T> void f();
-  template<typename T> struct S { int n; };
+  template<typename T> struct S { int n; }; // expected-note {{'::dr141::S<int>::n' declared here}}
   struct A : S<int> {
     template<typename T> void f();
     template<typename T> struct S {};
   } a;
   struct B : S<int> {} b;
   void g() {
     a.f<int>();
-    (void)a.S<int>::n; // expected-error {{no member named 'n'}}
+    (void)a.S<int>::n; // expected-error {{no member named 'n' in 'dr141::A::S<int>'; did you mean '::dr141::S<int>::n'?}}
 #if __cplusplus < 201103L
     // expected-error@-2 {{ambiguous}}
     // expected-note@-11 {{lookup from the current scope}}
     // expected-note@-9 {{lookup in the object type}}
 #endif
     b.f<int>(); // expected-error {{no member}} expected-error +{{}}
     (void)b.S<int>::n;
   }