This is an archive of the discontinued LLVM Phabricator instance.

Differential D111297

[libcxx] [test] Make windows triples in XFAILs less specific
ClosedPublic

Authored by mstorsjo on Oct 7 2021, 4:17 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG6cac17e365a3: [libcxx] [test] Make windows triples in XFAILs less specific
Summary

This allows picking up on mingw triples that often use 'w64' instead
of 'pc' as the vendor part.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Oct 7 2021, 4:17 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2021, 4:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B127483: Diff 377797.Oct 7 2021, 5:11 AM
Mordante accepted this revision as: Mordante.Oct 7 2021, 8:43 AM
Mordante added a subscriber: Mordante.

LGTM.

ldionne accepted this revision.Oct 12 2021, 8:04 AM
This revision is now accepted and ready to land.Oct 12 2021, 8:04 AM
Closed by commit rG6cac17e365a3: [libcxx] [test] Make windows triples in XFAILs less specific (authored by mstorsjo). · Explain WhyOct 12 2021, 8:26 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG6cac17e365a3: [libcxx] [test] Make windows triples in XFAILs less specific.

Revision Contents

PathSize
libcxx/
test/
std/
depr/
depr.c.headers/
2 lines
language.support/
support.runtime/
2 lines

Diff 379049

libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp

Show All 10 Lines
// UNSUPPORTED: c++03, c++11, c++14 // UNSUPPORTED: c++03, c++11, c++14
// ::aligned_alloc is provided by the C library, but it's marked as unavailable // ::aligned_alloc is provided by the C library, but it's marked as unavailable
// until macOS 10.15 // until macOS 10.15
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}} // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
// ::aligned_alloc is not implemented on Windows // ::aligned_alloc is not implemented on Windows
// XFAIL: target={{.+}}-pc-windows-{{.+}} // XFAIL: target={{.+}}-windows-{{.+}}
#include <stdlib.h> #include <stdlib.h>
#include <type_traits> #include <type_traits>
static_assert(std::is_same<decltype(aligned_alloc(1, 0)), void*>::value, ""); static_assert(std::is_same<decltype(aligned_alloc(1, 0)), void*>::value, "");

libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp

Show All 10 Lines
// UNSUPPORTED: c++03, c++11, c++14 // UNSUPPORTED: c++03, c++11, c++14
// ::aligned_alloc is provided by the C library, but it's marked as unavailable // ::aligned_alloc is provided by the C library, but it's marked as unavailable
// until macOS 10.15 // until macOS 10.15
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}} // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
// ::aligned_alloc is not implemented on Windows // ::aligned_alloc is not implemented on Windows
// XFAIL: target={{.+}}-pc-windows-{{.+}} // XFAIL: target={{.+}}-windows-{{.+}}
#include <cstdlib> #include <cstdlib>
#include <type_traits> #include <type_traits>
static_assert(std::is_same<decltype(std::aligned_alloc(1, 0)), void*>::value, ""); static_assert(std::is_same<decltype(std::aligned_alloc(1, 0)), void*>::value, "");