This is an archive of the discontinued LLVM Phabricator instance.

Differential D111043

libc++: document in the release notes that a C++20 compiler is expected
ClosedPublic

Authored by sylvestre.ledru on Oct 4 2021, 2:10 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rGc788bea24355: libc++: document in the release notes that a C++20 compiler is expected

Diff Detail

Event Timeline

sylvestre.ledru requested review of this revision.Oct 4 2021, 2:10 AM
sylvestre.ledru created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2021, 2:10 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B126799: Diff 376827.Oct 4 2021, 2:10 AM
sylvestre.ledru mentioned this in D110338: [libc++] Require a C++20 capable compiler..Oct 4 2021, 2:10 AM
ldionne accepted this revision.Oct 4 2021, 9:58 AM

We need to draw a distinction between using libc++ with pre-C++20 standard modes (which is entirely supported) and building the dylib itself, which does require C++20 support.

LGTM with my suggested change.

libcxx/docs/ReleaseNotes.rst
57
This revision is now accepted and ready to land.Oct 4 2021, 9:58 AM
Closed by commit rGc788bea24355: libc++: document in the release notes that a C++20 compiler is expected (authored by sylvestre.ledru). · Explain WhyOct 4 2021, 10:03 AM
This revision was automatically updated to reflect the committed changes.
sylvestre.ledru added a commit: rGc788bea24355: libc++: document in the release notes that a C++20 compiler is expected.

Revision Contents

PathSize
libcxx/
docs/
7 lines

Diff 376934

libcxx/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
- There's a new CMake option ``LIBCXX_ENABLE_UNICODE`` to disable Unicode - There's a new CMake option ``LIBCXX_ENABLE_UNICODE`` to disable Unicode
support in the ``<format>`` header. This only affects the estimation of the support in the ``<format>`` header. This only affects the estimation of the
output width of the format functions. output width of the format functions.
API Changes API Changes
----------- -----------
- ... - ...
Build System Changes
--------------------
- Building the libc++ shared or static library requires a C++ 20 capable compiler.
ldionneUnsubmitted
Not Done
ReplyInline Actions
--------------------
- - libc++ requires a C++ 20 capable compiler.
+ - Building the libc++ shared or static library requires a C++ 20 capable compiler.
Use ``-DLLVM_ENABLE_PROJECTS='clang;compiler-rt' -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi'``
ldionne:
Use ``-DLLVM_ENABLE_PROJECTS='clang;compiler-rt' -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi'``
to build libc++ using a fresh build of Clang.