bugprone-virtual-near-miss & performance-type-promotion-in-math-fn
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, please let me know what name and email address you would like me to use for patch attribution in git.
Comment Actions
I'm not certain how, but somehow this review is set to be uneditable, so I cannot mark it as accepted (or close it later once it lands).
bakinovsky-m created this object with edit policy "Administrators".
I think you may need to edit the review's policy so it goes back to whatever the default is.
Comment Actions
My bad, should be editable now
Yes, please. Name: "M Bakinovsky", email: "mbtrash@yandex.ru"
Thanks!
Comment Actions
Any time, thank you for the fixes! I've commit on your behalf in 4f01a02d738b033c10bfed5b47014fc197509a4f.