This is an archive of the discontinued LLVM Phabricator instance.

[docs] fix docs for bugprone-virtual-near-miss & performance-type-promotion-in-math-fn
ClosedPublic

Authored by bakinovsky-m on Sep 27 2021, 2:13 AM.

Details

Reviewers
aaron.ballman
Summary

bugprone-virtual-near-miss & performance-type-promotion-in-math-fn

Diff Detail

Event Timeline

bakinovsky-m requested review of this revision.Sep 27 2021, 2:13 AM
bakinovsky-m created this revision.
bakinovsky-m created this object with edit policy "Administrators".

Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, please let me know what name and email address you would like me to use for patch attribution in git.

I'm not certain how, but somehow this review is set to be uneditable, so I cannot mark it as accepted (or close it later once it lands).

bakinovsky-m created this object with edit policy "Administrators".

I think you may need to edit the review's policy so it goes back to whatever the default is.

bakinovsky-m changed the edit policy from "Administrators" to "All Users".Sep 28 2021, 12:57 AM

I'm not certain how, but somehow this review is set to be uneditable, so I cannot mark it as accepted (or close it later once it lands).

bakinovsky-m created this object with edit policy "Administrators".

I think you may need to edit the review's policy so it goes back to whatever the default is.

My bad, should be editable now

Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, please let me know what name and email address you would like me to use for patch attribution in git.

Yes, please. Name: "M Bakinovsky", email: "mbtrash@yandex.ru"

Thanks!

aaron.ballman accepted this revision.Sep 28 2021, 3:58 AM

Thanks for the fixes, LGTM! Do you need me to commit on your behalf? If so, please let me know what name and email address you would like me to use for patch attribution in git.

Yes, please. Name: "M Bakinovsky", email: "mbtrash@yandex.ru"

Thanks!

Any time, thank you for the fixes! I've commit on your behalf in 4f01a02d738b033c10bfed5b47014fc197509a4f.

This revision is now accepted and ready to land.Sep 28 2021, 3:58 AM