This is an archive of the discontinued LLVM Phabricator instance.

Write test for CWG1772/CWG1779, mark them 'done', and update cxx_dr_status.html
ClosedPublic

Authored by erichkeane on Sep 24 2021, 8:35 AM.

Details

Summary

I noticed that these two DRs are currently working correctly, so I
added a pair of lit tests that check the AST (which is most useful for
CWG1779, since 'dependent' is really only observable in an ast dump) to
make sure __func__ works correctly in dependent cases, and in lambda
operator().

Also noticed that CWG1762, mostly an 'example' change, works correctly,
so added a test so that it gets marked 'done' as well.

Additionally, I regenerated cxx_dr_status.html, updating it for Clang
13's release, based on the cwg_status.html from August 12, 2021.

Diff Detail

Event Timeline

erichkeane requested review of this revision.Sep 24 2021, 8:35 AM
erichkeane created this revision.
erichkeane edited the summary of this revision. (Show Details)
erichkeane edited the summary of this revision. (Show Details)

Add test for CWG1762, since it was easy enough and in the same area.

aaron.ballman accepted this revision.Sep 24 2021, 10:03 AM

LGTM aside from some nits, thank you!

clang/test/CXX/drs/dr17xx.cpp
75

Unintentional whitespace changes can be backed out. ;-)

132
clang/www/make_cxx_dr_status
95

Errr, 13 isn't quite out the door yet (we've branched for it, but not released it). However, I don't think it's an issue to bump the value right now (IIUC, we're releasing Very Soon Now anyway).

This revision is now accepted and ready to land.Sep 24 2021, 10:03 AM