This is an archive of the discontinued LLVM Phabricator instance.

[doc] documentation of code review tools
Needs ReviewPublic

Authored by kuhnel on Sep 15 2021, 12:45 AM.

Details

Summary

Different LLVM projects on GitHub use different code review tools. This patch updates our developer policy to document which review tool is used where. This is based on the discussion in https://github.com/llvm/llvm-iwg/issues/21

Note: We're not changing which tool is used, we only document the current state.

Authored-by: @agerbes , I posting this on her behalf.

Diff Detail

Event Timeline

kuhnel requested review of this revision.Sep 15 2021, 12:45 AM
kuhnel created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2021, 12:45 AM
kuhnel retitled this revision from documentation of code review tools to [doc] documentation of code review tools.Sep 15 2021, 12:49 AM
kuhnel edited the summary of this revision. (Show Details)
kuhnel added reviewers: agerbes, reames.
kuhnel added a subscriber: agerbes.
kuhnel updated this revision to Diff 379349.Oct 13 2021, 5:12 AM
kuhnel edited the summary of this revision. (Show Details)

2nd iteration of the patch

Changes:

  • added a bit of boilerplate text
  • changed the links to be simpler to read
  • removed the project that haven't been updated in a long time or are not performing code reviews
xgupta added a subscriber: xgupta.Oct 13 2021, 9:16 AM

They are listed in random order, listing them according to their activity would be better.

llvm/docs/DeveloperPolicy.rst
141
142
153
153

better if we have one review tool to contribute, only phabricator would be the right place for llvm-www.

155

mlir-npcomp renamed to torch-mlir.

reames requested changes to this revision.Oct 13 2021, 9:22 AM
reames added inline comments.
llvm/docs/DeveloperPolicy.rst
131

I request a minor reframing here. Please describe phabricator as the default, and list the github pull requests as the exception to the general policy.

I'd also leave out any where there's been a mix of both. We should bias those towards phabricator unless that particular community desires otherwise. (i.e. contributes their own follow up to list themselves as PRs)

146

Order wise, either alphabetical or popularity. I'd prefer alphabetical.

This revision now requires changes to proceed.Oct 13 2021, 9:22 AM
kuhnel updated this revision to Diff 402491.Jan 24 2022, 5:43 AM
kuhnel marked 7 inline comments as done.

Thx @reames and @xgupta for your review! I hopefully addressed all of them.

Sorry for the slow response rate. I'd actually like to wrap this up rather sonner than later.

llvm/docs/DeveloperPolicy.rst
146

Using alphabetical as it's easier to do and maintain.

xgupta accepted this revision.Jan 26 2022, 8:30 AM

LGTM, Thanks!

Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2022, 8:42 AM

This looks good to me.

xgupta resigned from this revision.Nov 29 2022, 7:50 PM