This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Use lib_dirs instead of putting a qualified path in libs for diaguids.lib
ClosedPublic

Authored by thakis on Sep 14 2021, 8:30 AM.

Details

Summary

Follow-up to D109708: Using lib_dirs means this will work with ancient gn binaries.

Change the toolchain definitions to make lib_dirs have the right effect, and
pull out lib_switch of each of the tools while here.

This means we now do pass /LIBPATH: to link.exe, but since we invoke it directly
and not through clang-cl, this doesn't actually require D109624. And since this
is built in to GN, we don't need a config to push the flag to dependents.

This is arguably a bit more idiomatic, and it doesn't require folks to upload
their GN binaries. No effective behavior change.

Diff Detail

Event Timeline

thakis created this revision.Sep 14 2021, 8:30 AM
thakis requested review of this revision.Sep 14 2021, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2021, 8:30 AM
hans accepted this revision.Sep 14 2021, 9:08 AM

lgtm

Commit message nit:

This is arguably a bit more idiomatic, and it doesn't require folks to upload

s/upload/update/

This revision is now accepted and ready to land.Sep 14 2021, 9:08 AM
This revision was landed with ongoing or failed builds.Sep 14 2021, 9:32 AM
This revision was automatically updated to reflect the committed changes.