This is an archive of the discontinued LLVM Phabricator instance.

Differential D109358

Add llvm-ml to LLVM_TOOLCHAIN_TOOLS (PR50536)
ClosedPublic

Authored by hans on Sep 7 2021, 5:36 AM.

Details

Reviewers
thakis
Commits
rGc364dcbf1fd8: Add llvm-ml to LLVM_TOOLCHAIN_TOOLS (PR50536)
Summary

so that it gets installed in LLVM_INSTALL_TOOLCHAIN_ONLY builds,
such as used by the Windows installer.

Diff Detail

Event Timeline

hans created this revision.Sep 7 2021, 5:36 AM
Herald added a subscriber: mgorny. · View Herald TranscriptSep 7 2021, 5:36 AM
hans requested review of this revision.Sep 7 2021, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2021, 5:36 AM
Harbormaster completed remote builds in B122857: Diff 371046.Sep 7 2021, 6:13 AM
thakis accepted this revision.Sep 7 2021, 7:53 AM
This revision is now accepted and ready to land.Sep 7 2021, 7:53 AM
thakis added a comment.Sep 7 2021, 7:54 AM

lgtm

Closed by commit rGc364dcbf1fd8: Add llvm-ml to LLVM_TOOLCHAIN_TOOLS (PR50536) (authored by hans). · Explain WhySep 7 2021, 7:55 AM
This revision was automatically updated to reflect the committed changes.
hans added a commit: rGc364dcbf1fd8: Add llvm-ml to LLVM_TOOLCHAIN_TOOLS (PR50536).

Revision Contents

PathSize
llvm/
cmake/
modules/
1 line

Diff 371079

llvm/cmake/modules/AddLLVM.cmake

Show First 20 Lines • Show All 1,198 Lines • ▼ Show 20 Lines
if(NOT LLVM_TOOLCHAIN_TOOLS) if(NOT LLVM_TOOLCHAIN_TOOLS)
set (LLVM_TOOLCHAIN_TOOLS set (LLVM_TOOLCHAIN_TOOLS
llvm-ar llvm-ar
llvm-cov llvm-cov
llvm-cxxfilt llvm-cxxfilt
llvm-ranlib llvm-ranlib
llvm-lib llvm-lib
llvm-ml
llvm-nm llvm-nm
llvm-objcopy llvm-objcopy
llvm-objdump llvm-objdump
llvm-rc llvm-rc
llvm-readobj llvm-readobj
llvm-size llvm-size
llvm-strings llvm-strings
llvm-strip llvm-strip
▲ Show 20 Lines • Show All 998 Lines • Show Last 20 Lines