This is an archive of the discontinued LLVM Phabricator instance.

Fix compilation error with older libstdc++
Needs ReviewPublic

Authored by vadimcn on Sep 6 2021, 4:55 PM.

Details

Reviewers
jingham
Summary

Until GCC 6, std::unordered_map could not emplace non-copyable values, which results in this error: "error: call to implicitly-deleted copy constructor of 'lldb_private::ThreadPlanStack'" (due to ThreadPlanStack::m_stack_mutex not being copyable). Using std::piecewise_construct works around this problem.

Diff Detail

Event Timeline

vadimcn created this revision.Sep 6 2021, 4:55 PM
vadimcn requested review of this revision.Sep 6 2021, 4:55 PM
vadimcn updated this revision to Diff 372391.Sep 13 2021, 8:21 PM

Re-formatted