This is an archive of the discontinued LLVM Phabricator instance.

Differential D109168

[Unwind] Cast exception class pointer for strcpy
ClosedPublic

Authored by hans on Sep 2 2021, 9:46 AM.

Details

Reviewers
danielkiss
compnerd
Group Reviewers
Restricted Project
Commits
rG1bc175d486b5: [Unwind] Cast exception class pointer for strcpy
Summary

Follow-up to f5b997e6b706, see comment on https://reviews.llvm.org/D109047

Diff Detail

Event Timeline

hans created this revision.Sep 2 2021, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 9:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
hans requested review of this revision.Sep 2 2021, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 9:46 AM
hans mentioned this in D109047: [Unwind] Harmonise exception class for EHABI spec..Sep 2 2021, 9:46 AM
danielkiss accepted this revision.Sep 2 2021, 9:48 AM

LGTM, thanks.

compnerd accepted this revision.Sep 2 2021, 9:48 AM
This revision is now accepted and ready to land.Sep 2 2021, 9:48 AM
This revision was landed with ongoing or failed builds.Sep 2 2021, 10:01 AM
Closed by commit rG1bc175d486b5: [Unwind] Cast exception class pointer for strcpy (authored by hans). · Explain Why
This revision was automatically updated to reflect the committed changes.
hans added a commit: rG1bc175d486b5: [Unwind] Cast exception class pointer for strcpy.
Harbormaster completed remote builds in B122335: Diff 370308.Sep 2 2021, 10:13 AM

Revision Contents

PathSize
libunwind/
src/
2 lines

Diff 370312

libunwind/src/UnwindLevel1-gcc-ext.c

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines_Unwind_Backtrace(_Unwind_Trace_Fn callback, void *ref) {
_LIBUNWIND_TRACE_API("_Unwind_Backtrace(callback=%p)", _LIBUNWIND_TRACE_API("_Unwind_Backtrace(callback=%p)",
(void *)(uintptr_t)callback); (void *)(uintptr_t)callback);
#if defined(_LIBUNWIND_ARM_EHABI) #if defined(_LIBUNWIND_ARM_EHABI)
// Create a mock exception object for force unwinding. // Create a mock exception object for force unwinding.
_Unwind_Exception ex; _Unwind_Exception ex;
memset(&ex, '\0', sizeof(ex)); memset(&ex, '\0', sizeof(ex));
strcpy(&ex.exception_class, "CLNGUNW"); strcpy((char *)&ex.exception_class, "CLNGUNW");
#endif #endif
// walk each frame // walk each frame
while (true) { while (true) {
_Unwind_Reason_Code result; _Unwind_Reason_Code result;
#if !defined(_LIBUNWIND_ARM_EHABI) #if !defined(_LIBUNWIND_ARM_EHABI)
// ask libunwind to get next frame (skip over first frame which is // ask libunwind to get next frame (skip over first frame which is
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines