This is an archive of the discontinued LLVM Phabricator instance.

Run coro::salavageDebugInfo on dbg.declares in entry function
AbandonedPublic

Authored by aprantl on Sep 1 2021, 6:17 PM.

Details

Reviewers
lxfind
bruno
Summary

While looking through diffs between the Swift branch and llvm.org if found the following patch that I previously forgot to upstream. The patch also calls coro::salavageDebugInf()o on all dbg.declares in entry function. This is necessary for Swift because in the Swift calling convention the entry function can already have a coroutine context argument. I believe that the patch is neutral for C++ coroutines at -O0 (and mildly beneficial at -O), as it does rewrite dbg.declares to point into the freshly setup coroutine frame, as shown in the updated test.

Diff Detail

Event Timeline

aprantl created this revision.Sep 1 2021, 6:17 PM
aprantl requested review of this revision.Sep 1 2021, 6:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 6:17 PM

Ping. Any objections to this?

aprantl abandoned this revision.Mar 9 2022, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2022, 12:46 PM