This is an archive of the discontinued LLVM Phabricator instance.

Differential D108896

[libc++abi] Avoid the waring: "__EXCEPTIONS" is not defined, evaluates to 0 [-Werror=undef]
ClosedPublic

Authored by xiaoxiang781216 on Aug 29 2021, 12:10 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGed4946fe2096: [libc++abi] Avoid the warning: "__EXCEPTIONS" is not defined, evaluates to 0…

Diff Detail

Event Timeline

xiaoxiang781216 requested review of this revision.Aug 29 2021, 12:10 PM
xiaoxiang781216 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2021, 12:10 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B121666: Diff 369334.Aug 29 2021, 1:20 PM
ldionne accepted this revision.Aug 30 2021, 10:33 AM
This revision is now accepted and ready to land.Aug 30 2021, 10:33 AM
ldionne added a comment.Aug 30 2021, 10:34 AM

Nit: you have a typo in your commit message (waring should be warning).

Closed by commit rGed4946fe2096: [libc++abi] Avoid the warning: "__EXCEPTIONS" is not defined, evaluates to 0… (authored by xiaoxiang781216, committed by ldionne). · Explain WhyAug 30 2021, 10:34 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGed4946fe2096: [libc++abi] Avoid the warning: "__EXCEPTIONS" is not defined, evaluates to 0….
xiaoxiang781216 added a comment.Aug 31 2021, 3:24 AM
In D108896#2972613, @ldionne wrote:

Nit: you have a typo in your commit message (waring should be warning).

Thanks for fix the typo.

Revision Contents

PathSize
libcxxabi/
include/
2 lines

Diff 369486

libcxxabi/include/__cxxabi_config.h

Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines
#if defined(__arm__) || defined(__wasm32__) || defined(__ARM64_ARCH_8_32__) #if defined(__arm__) || defined(__wasm32__) || defined(__ARM64_ARCH_8_32__)
# define _LIBCXXABI_GUARD_ABI_ARM # define _LIBCXXABI_GUARD_ABI_ARM
#endif #endif
#if defined(_LIBCXXABI_COMPILER_CLANG) #if defined(_LIBCXXABI_COMPILER_CLANG)
# if !__has_feature(cxx_exceptions) # if !__has_feature(cxx_exceptions)
# define _LIBCXXABI_NO_EXCEPTIONS # define _LIBCXXABI_NO_EXCEPTIONS
# endif # endif
#elif defined(_LIBCXXABI_COMPILER_GCC) && !__EXCEPTIONS #elif defined(_LIBCXXABI_COMPILER_GCC) && !defined(__EXCEPTIONS)
# define _LIBCXXABI_NO_EXCEPTIONS # define _LIBCXXABI_NO_EXCEPTIONS
#endif #endif
#endif // ____CXXABI_CONFIG_H #endif // ____CXXABI_CONFIG_H