This is an archive of the discontinued LLVM Phabricator instance.

Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR in the sanitizer symbolizer build.
ClosedPublic

Authored by eugenis on Aug 27 2021, 1:39 PM.

Details

Summary

In this mode libc++ headers end up in two directories:

  • include/<triple>/c++/v1 for the site config header
  • include/c++/v1 for everything else

Also switch from -I to -isystem.

Diff Detail

Event Timeline

eugenis requested review of this revision.Aug 27 2021, 1:39 PM
eugenis created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2021, 1:39 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Something like this? Still testing...

MaskRay accepted this revision.Aug 27 2021, 1:43 PM

Thanks! -isystem ignores non-existent directory, so -isystem ${LIBCXX_BUILD}/include/${TARGET_TRIPLE}/c++/v1 should be good.

This revision is now accepted and ready to land.Aug 27 2021, 1:43 PM
This revision was landed with ongoing or failed builds.Aug 27 2021, 1:50 PM
This revision was automatically updated to reflect the committed changes.