[libc] Fix type errors on Windows

[michaelrj]

Summary

Fix the errors caused by having some numbers too large for a 32 bit
number in the tests for windows. Also fix the base causing some type
confusion.

[michaelrj]

fix typo in commit message

libc/test/src/stdlib/strtol_test.cpp

TEST(LlvmLibcStrToLTest, CleanBaseTenDecode) {
   EXPECT_EQ(str_end - hundred, ptrdiff_t(3));
 
   const char *negative = "-100";
   errno = 0;
   ASSERT_EQ(__llvm_libc::strtol(negative, &str_end, 10), -100l);
   ASSERT_EQ(errno, 0);
   EXPECT_EQ(str_end - negative, ptrdiff_t(4));
 
-  const char *big_number = "123456789012345";
+  const char *big_number = "1234567890";
   errno = 0;
-  ASSERT_EQ(__llvm_libc::strtol(big_number, &str_end, 10), 123456789012345l);
+  ASSERT_EQ(__llvm_libc::strtol(big_number, &str_end, 10), 1234567890l);
   ASSERT_EQ(errno, 0);
-  EXPECT_EQ(str_end - big_number, ptrdiff_t(15));
+  EXPECT_EQ(str_end - big_number, ptrdiff_t(10));
 
-  const char *big_negative_number = "-123456789012345";
+  const char *big_negative_number = "-1234567890";
   errno = 0;
   ASSERT_EQ(__llvm_libc::strtol(big_negative_number, &str_end, 10),
-            -123456789012345l);
+            -1234567890l);
   ASSERT_EQ(errno, 0);
-  EXPECT_EQ(str_end - big_negative_number, ptrdiff_t(16));
+  EXPECT_EQ(str_end - big_negative_number, ptrdiff_t(11));
 
   const char *too_big_number = "123456789012345678901";
   errno = 0;
   ASSERT_EQ(__llvm_libc::strtol(too_big_number, &str_end, 10), LONG_MAX);
   ASSERT_EQ(errno, ERANGE);
   EXPECT_EQ(str_end - too_big_number, ptrdiff_t(21));
 
   const char *too_big_negative_number = "-123456789012345678901";
if (input < 0 || input > 36)
     return '0';
   if (input < 10)
     return '0' + input;
   return 'A' + input - 10;
 }
 
 TEST(LlvmLibcStrToLTest, DecodeInOtherBases) {
   char small_string[4] = {'\0', '\0', '\0', '\0'};
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (long base = 2; base <= 36; ++base) {
     for (long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       if (first_digit < base) {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtol(small_string, nullptr, base),
                   first_digit);
         ASSERT_EQ(errno, 0);
       } else {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtol(small_string, nullptr, base), 0l);
         ASSERT_EQ(errno, 0);
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (long base = 2; base <= 36; ++base) {
     for (long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (long second_digit = 0; second_digit <= 36; ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         if (first_digit < base && second_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtol(small_string, nullptr, base),
                     second_digit + (first_digit * base));
           ASSERT_EQ(errno, 0);
         } else if (first_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtol(small_string, nullptr, base),
                     first_digit);
           ASSERT_EQ(errno, 0);
         } else {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtol(small_string, nullptr, base), 0l);
           ASSERT_EQ(errno, 0);
         }
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (long base = 2; base <= 36; ++base) {
     for (long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (long second_digit = 0; second_digit <= 36; ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         for (long third_digit = 0; third_digit <= 36; ++third_digit) {
           small_string[2] = int_to_b36_char(third_digit);
 
           if (first_digit < base && second_digit < base && third_digit < base) {

libc/test/src/stdlib/strtoll_test.cpp

if (input < 0 || input > 36)
     return '0';
   if (input < 10)
     return '0' + input;
   return 'A' + input - 10;
 }
 
 TEST(LlvmLibcStrToLLTest, DecodeInOtherBases) {
   char small_string[4] = {'\0', '\0', '\0', '\0'};
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (long long base = 2; base <= 36; ++base) {
     for (long long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       if (first_digit < base) {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtoll(small_string, nullptr, base),
                   first_digit);
         ASSERT_EQ(errno, 0);
       } else {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtoll(small_string, nullptr, base), 0ll);
         ASSERT_EQ(errno, 0);
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (long long base = 2; base <= 36; ++base) {
     for (long long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (long long second_digit = 0; second_digit <= 36; ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         if (first_digit < base && second_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoll(small_string, nullptr, base),
                     second_digit + (first_digit * base));
           ASSERT_EQ(errno, 0);
         } else if (first_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoll(small_string, nullptr, base),
                     first_digit);
           ASSERT_EQ(errno, 0);
         } else {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoll(small_string, nullptr, base), 0ll);
           ASSERT_EQ(errno, 0);
         }
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (long long base = 2; base <= 36; ++base) {
     for (long long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (long long second_digit = 0; second_digit <= 36; ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         for (long long third_digit = 0; third_digit <= 36; ++third_digit) {
           small_string[2] = int_to_b36_char(third_digit);
 
           if (first_digit < base && second_digit < base && third_digit < base) {

libc/test/src/stdlib/strtoul_test.cpp

if (input < 0 || input > 36)
     return '0';
   if (input < 10)
     return '0' + input;
   return 'A' + input - 10;
 }
 
 TEST(LlvmLibcStrToULTest, DecodeInOtherBases) {
   char small_string[4] = {'\0', '\0', '\0', '\0'};
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (unsigned long base = 2; base <= 36; ++base) {
     for (unsigned long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       if (first_digit < base) {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtoul(small_string, nullptr, base),
                   first_digit);
         ASSERT_EQ(errno, 0);
       } else {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtoul(small_string, nullptr, base), 0ul);
         ASSERT_EQ(errno, 0);
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (unsigned long base = 2; base <= 36; ++base) {
     for (unsigned long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (unsigned long second_digit = 0; second_digit <= 36; ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         if (first_digit < base && second_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoul(small_string, nullptr, base),
                     second_digit + (first_digit * base));
           ASSERT_EQ(errno, 0);
         } else if (first_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoul(small_string, nullptr, base),
                     first_digit);
           ASSERT_EQ(errno, 0);
         } else {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoul(small_string, nullptr, base), 0ul);
           ASSERT_EQ(errno, 0);
         }
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (unsigned long base = 2; base <= 36; ++base) {
     for (unsigned long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (unsigned long second_digit = 0; second_digit <= 36; ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         for (unsigned long third_digit = 0; third_digit <= 36; ++third_digit) {
           small_string[2] = int_to_b36_char(third_digit);
 
           if (first_digit < base && second_digit < base && third_digit < base) {

libc/test/src/stdlib/strtoull_test.cpp

if (input < 0 || input > 36)
     return '0';
   if (input < 10)
     return '0' + input;
   return 'A' + input - 10;
 }
 
 TEST(LlvmLibcStrToULLTest, DecodeInOtherBases) {
   char small_string[4] = {'\0', '\0', '\0', '\0'};
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (unsigned long long base = 2; base <= 36; ++base) {
     for (unsigned long long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       if (first_digit < base) {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtoull(small_string, nullptr, base),
                   first_digit);
         ASSERT_EQ(errno, 0);
       } else {
         errno = 0;
         ASSERT_EQ(__llvm_libc::strtoull(small_string, nullptr, base), 0ull);
         ASSERT_EQ(errno, 0);
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (unsigned long long base = 2; base <= 36; ++base) {
     for (unsigned long long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (unsigned long long second_digit = 0; second_digit <= 36;
            ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         if (first_digit < base && second_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoull(small_string, nullptr, base),
                     second_digit + (first_digit * base));
           ASSERT_EQ(errno, 0);
         } else if (first_digit < base) {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoull(small_string, nullptr, base),
                     first_digit);
           ASSERT_EQ(errno, 0);
         } else {
           errno = 0;
           ASSERT_EQ(__llvm_libc::strtoull(small_string, nullptr, base), 0ull);
           ASSERT_EQ(errno, 0);
         }
       }
     }
   }
 
-  for (unsigned int base = 2; base <= 36; ++base) {
+  for (unsigned long long base = 2; base <= 36; ++base) {
     for (unsigned long long first_digit = 0; first_digit <= 36; ++first_digit) {
       small_string[0] = int_to_b36_char(first_digit);
       for (unsigned long long second_digit = 0; second_digit <= 36;
            ++second_digit) {
         small_string[1] = int_to_b36_char(second_digit);
         for (unsigned long long third_digit = 0; third_digit <= 36;
              ++third_digit) {
           small_string[2] = int_to_b36_char(third_digit);