This is an archive of the discontinued LLVM Phabricator instance.

Differential D108409

[libc] make the scudo integration test run
ClosedPublic

Authored by michaelrj on Aug 19 2021, 2:09 PM.

Download Raw Diff

Details

Reviewers

Commits

rG6ce6fa4ad430: [libc] make the scudo integration test run

Summary

adds a custom command for libc-scudo-integration-test that makes it run
when it is built.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

michaelrj created this revision.Aug 19 2021, 2:09 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 2:09 PM

Herald added subscribers: libc-commits, ecnelises, tschuett and 2 others. · View Herald Transcript

michaelrj requested review of this revision.Aug 19 2021, 2:09 PM

Harbormaster completed remote builds in B120421: Diff 367610.Aug 19 2021, 2:55 PM

I think you need to fix the commit message - you probably mean't to say custom command instead of custom target.

This revision is now accepted and ready to land.Aug 19 2021, 9:13 PM

update commit message

michaelrj edited the summary of this revision. (Show Details)Aug 20 2021, 10:25 AM

This revision was landed with ongoing or failed builds.Aug 20 2021, 10:51 AM

Closed by commit rG6ce6fa4ad430: [libc] make the scudo integration test run (authored by michaelrj). · Explain Why

This revision was automatically updated to reflect the committed changes.

michaelrj added a commit: rG6ce6fa4ad430: [libc] make the scudo integration test run.

Harbormaster completed remote builds in B120578: Diff 367826.Aug 20 2021, 11:05 AM

Revision Contents

Path

Size

libc/

test/

integration/

scudo/

6 lines

Diff 367834

libc/test/integration/scudo/CMakeLists.txt

	Show All 31 Lines		target_link_options(
	# "-nolibc"			# "-nolibc"
	-pthreads			-pthreads
	)			)

	target_link_libraries(libc-gwp-asan-uaf-should-crash			target_link_libraries(libc-gwp-asan-uaf-should-crash
	PRIVATE			PRIVATE
	llvmlibc			llvmlibc
	)			)

				add_custom_command(TARGET libc-scudo-integration-test
				POST_BUILD
				COMMAND $<TARGET_FILE:libc-scudo-integration-test>
				COMMENT "Run the test after it is built."
				VERBATIM)