Page MenuHomePhabricator

[NFC] computeSPIRKernelABIInfo(): use SPIRABInfo
AcceptedPublic

Authored by linjamaki on Aug 19 2021, 5:16 AM.

Details

Reviewers
Anastasia
Summary

Make computeSPIRKernelABIInfo() to use SPIRABIInfo instead of
DefaultABIInfo.

Diff Detail

Event Timeline

linjamaki requested review of this revision.Aug 19 2021, 5:16 AM
linjamaki created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 5:16 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Anastasia accepted this revision.Aug 25 2021, 2:42 AM

LGTM! Thanks.

Do you think we can test this somehow?

This revision is now accepted and ready to land.Aug 25 2021, 2:42 AM

Thanks for the review.

In an upcoming HIPSPV patch there will be a test that depends on this change.

@Anastasia I used to have svn commit access, but haven't committed anything for a long while in LLVM, so don't know if I can get them back to github by just asking. So, can you please commit these HIPSPV patches for us?

@Anastasia I used to have svn commit access, but haven't committed anything for a long while in LLVM, so don't know if I can get them back to github by just asking. So, can you please commit these HIPSPV patches for us?

@Anastasia - or do you think there's someone else more suitable for pushing these patches in for us? Thanks.