Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping.

[RedX2501]

The code owners file says you are the owner of all parts that do not belong to somebody else. So i hope it is ok if i attach you as reviewer to this.

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping

[rsmith]

include/clang-c/Index.h

3815–3823

It might be better to combine these into a single function (getLocalVarKind?) returning an enum { not local, non-static local, static local }.

[RedX2501]

include/clang-c/Index.h

3815–3823

Combining these into one function with an enum is much more work when porting to python (which is also den in this patch). Therefore unless there are reasons beyond stylistic ones i'd prefer to keep them separate.

IMHO this also increases the friendliness as you can directly infer from the documentation at http://clang.llvm.org/doxygen/ what they should do as they just forward the calls..

[rsmith]

Argyrios, I'd appreciate your thoughts here.

tools/libclang/CIndex.cpp

6670–6694

I don't think the names of these are really specific enough for what they do. As members of VarDecl, they're good enough, but as operations on a general Cursor, it's less so. For instance, temporary objects in C++ might also have local storage or be static locals. Renaming isStaticLocal to isStaticLocalVar would help.

hasLocalStorage is not really a very user-friendly name for this functionality, even though it currently matches our C++ API (the C API has long-term stability guarantees whereas the C++ API does not, so we need to take more care when naming C API functions, even though matching the C++ API does generally make the C API more user-friendly). isStaticLocalVar versus isNonStaticLocalVar might be better if you don't want to go the enum route.

[RedX2501]

No longer export two functions but only one.

On further thought I only need the information is the variable was declared local or not. I don't really need the information where the storage ultimately is.

Added python and libclang tests.

[RedX2501]

Ping

[RedX2501]

Ping

[akyrtzi]

The patch does not apply cleanly, could you provide a more up-to-date one ?

[RedX2501]

Fixed compiler warnings.

[RedX2501]

Fix compilation error introduced due to breaking a long string.
Fixed indentation.

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping

[RedX2501]

Ping?

bindings/python/clang/cindex.py

def referenced(self):
         representing the entity that it references.
         """
         if not hasattr(self, '_referenced'):
             self._referenced = conf.lib.clang_getCursorReferenced(self)
 
         return self._referenced
 
     @property
+    def has_local_storage(self):
+        if not hasattr(self, '_localstorage'):
+            self._localstorage = conf.lib.clang_Cursor_hasLocalStorage(self)
+
+        return self._localstorage
+
+    @property
+    def is_static_local(self):
+        if not hasattr(self, '_staticlocal'):
+            self._staticlocal = conf.lib.clang_Cursor_isStaticLocal(self)
+
+        return self._staticlocal
+
+    @property
     def brief_comment(self):
         """Returns the brief comment text associated with that Cursor"""
         return conf.lib.clang_Cursor_getBriefCommentText(self)
 
     @property
     def raw_comment(self):
         """Returns the raw comment text associated with that Cursor"""
         return conf.lib.clang_Cursor_getRawCommentText(self)

include/clang-c/Index.h

  */
 CINDEX_LINKAGE unsigned clang_Cursor_isObjCOptional(CXCursor C);
 
 /**
  * \brief Returns non-zero if the given cursor is a variadic function or method.
  */
 CINDEX_LINKAGE unsigned clang_Cursor_isVariadic(CXCursor C);
 
 /**
+ * \brief Returns true if a variable with function scope is a non-static local variable.
+ */
+CINDEX_LINKAGE bool clang_Cursor_hasLocalStorage(CXCursor C);
+
+/*
+ * \brief  Returns true if a variable with function scope is a static local variable.
+ */
+CINDEX_LINKAGE bool clang_Cursor_isStaticLocal(CXCursor C);
+
+/**
  * \brief Given a cursor that represents a declaration, return the associated
  * comment's source range.  The range may include multiple consecutive comments
  * with whitespace in between.
  */
 CINDEX_LINKAGE CXSourceRange clang_Cursor_getCommentRange(CXCursor C);
 
 /**
  * \brief Given a cursor that represents a declaration, return the associated

tools/libclang/CIndex.cpp

unsigned clang_Cursor_isVariadic(CXCursor C) {
   if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D))
     return FD->isVariadic();
   if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D))
     return MD->isVariadic();
 
   return 0;
 }
 
+bool clang_Cursor_hasLocalStorage(CXCursor C) {
+  if (C.kind != CXCursor_VarDecl) {
+    return false;
+  }
+
+  const Decl *D = getCursorDecl(C);
+  if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
+    return VD->hasLocalStorage();
+  }
+
+  return false;
+}
+
+bool clang_Cursor_isStaticLocal(CXCursor C) {
+  if (C.kind != CXCursor_VarDecl) {
+    return false;
+  }
+
+  const Decl *D = getCursorDecl(C);
+  if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
+    return VD->isStaticLocal();
+  }
+
+  return false;
+}
+
 CXSourceRange clang_Cursor_getCommentRange(CXCursor C) {
   if (!clang_isDeclaration(C.kind))
     return clang_getNullRange();
 
   const Decl *D = getCursorDecl(C);
   ASTContext &Context = getCursorContext(C);
   const RawComment *RC = Context.getRawCommentForAnyRedecl(D);
   if (!RC)