This is an archive of the discontinued LLVM Phabricator instance.

Differential D108191

[sanitizers] Fix building on 32 bit Windows after 7256c05ecb7
ClosedPublic

Authored by mstorsjo on Aug 17 2021, 12:38 AM.

Details

Reviewers
vitalybuka
Commits
rG18e06e3e2f3d: [sanitizers] Fix building on 32 bit Windows after 7256c05ecb7
Summary

On 32 bit, 'long' (which is 32 bit on Windows) is used as base
type for SIZE_T and similar.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Aug 17 2021, 12:38 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2021, 12:38 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B119846: Diff 366821.Aug 17 2021, 1:02 AM
vitalybuka accepted this revision.Aug 17 2021, 10:23 AM

Is there a broken bot?

This revision is now accepted and ready to land.Aug 17 2021, 10:23 AM
mstorsjo added a comment.Aug 17 2021, 10:33 AM
In D108191#2949862, @vitalybuka wrote:

Is there a broken bot?

Don’t know, but I run nightly builds for mingw targets as part of my own testing setup. I think all windows buildbots are x86_64 only.

Closed by commit rG18e06e3e2f3d: [sanitizers] Fix building on 32 bit Windows after 7256c05ecb7 (authored by mstorsjo). · Explain WhyAug 17 2021, 11:36 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG18e06e3e2f3d: [sanitizers] Fix building on 32 bit Windows after 7256c05ecb7.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 366968

compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h

Show First 20 Lines • Show All 133 Lines • ▼ Show 20 Lines
// in a portable way by the language itself. // in a portable way by the language itself.
namespace __sanitizer { namespace __sanitizer {
#if defined(_WIN64) #if defined(_WIN64)
// 64-bit Windows uses LLP64 data model. // 64-bit Windows uses LLP64 data model.
typedef unsigned long long uptr; typedef unsigned long long uptr;
typedef signed long long sptr; typedef signed long long sptr;
#else #else
# if (SANITIZER_WORDSIZE == 64) || SANITIZER_MAC # if (SANITIZER_WORDSIZE == 64) || SANITIZER_MAC || SANITIZER_WINDOWS
typedef unsigned long uptr; typedef unsigned long uptr;
typedef signed long sptr; typedef signed long sptr;
# else # else
typedef unsigned int uptr; typedef unsigned int uptr;
typedef signed int sptr; typedef signed int sptr;
# endif # endif
#endif // defined(_WIN64) #endif // defined(_WIN64)
#if defined(__x86_64__) #if defined(__x86_64__)
▲ Show 20 Lines • Show All 330 Lines • Show Last 20 Lines