This is an archive of the discontinued LLVM Phabricator instance.

Expand LangRef.html's documentation on LLVM's inline assembly.
ClosedPublic

Authored by jyknight on Jun 29 2015, 2:34 PM.

Details

Summary

While trying to figure out how this was all supposed to work, I
figured I'd start writing down some documentation, since it was
basically completely missing.

Diff Detail

Repository
rL LLVM

Event Timeline

jyknight updated this revision to Diff 28712.Jun 29 2015, 2:34 PM
jyknight retitled this revision from to Expand LangRef.html's documentation on LLVM's inline assembly..
jyknight updated this object.
jyknight edited the test plan for this revision. (Show Details)
jyknight added a reviewer: echristo.
jyknight added subscribers: dougk, Unknown Object (MLST).
dougk accepted this revision.Jun 30 2015, 7:05 AM
dougk added a reviewer: dougk.

This is phenomenal, thank you!
There's one typo and did you mean to keep the FIXMEs in documentation?

docs/LangRef.rst
2883 ↗(On Diff #28712)

registerf ?

This revision is now accepted and ready to land.Jun 30 2015, 7:05 AM

did you mean to keep the FIXMEs in documentation?

I did mean to, since they seem to be bugs, or need attention as to what the actual intent is.

But I'm open to other ways of expressing that.

echristo edited edge metadata.Jun 30 2015, 9:33 AM

Yeah, unless it's a comment that gets "compiled" out best not to have it.

I'll get to the rest soon.

Eric: you had more comments coming?

echristo accepted this revision.Jul 7 2015, 11:16 AM
echristo edited edge metadata.

Go ahead and put in the TargetLowering change spearately, check for typos ala dougk's comment, and that's it from me.

Thank you so very much for doing this!

-eric

This revision was automatically updated to reflect the committed changes.

Spell-checked, moved FIXMEs to rst "comments", so they show up only in the source, and double-checked formatted output. Thanks.