This is an archive of the discontinued LLVM Phabricator instance.

Differential D108118

tsan: fix unused var warnings in a test
ClosedPublic

Authored by dvyukov on Aug 16 2021, 4:09 AM.

Details

Reviewers
vitalybuka
melver
Commits
rG79aed89ea3af: tsan: fix unused var warnings in a test

Diff Detail

Event Timeline

dvyukov requested review of this revision.Aug 16 2021, 4:09 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2021, 4:09 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Aug 16 2021, 4:09 AM
This revision is now accepted and ready to land.Aug 16 2021, 4:09 AM
dvyukov mentioned this in D107911: tsan: add new trace.Aug 16 2021, 4:12 AM
This revision was landed with ongoing or failed builds.Aug 16 2021, 4:13 AM
Closed by commit rG79aed89ea3af: tsan: fix unused var warnings in a test (authored by dvyukov). · Explain Why
This revision was automatically updated to reflect the committed changes.
dvyukov added a commit: rG79aed89ea3af: tsan: fix unused var warnings in a test.
Harbormaster completed remote builds in B119679: Diff 366585.Aug 16 2021, 4:31 AM

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
tests/
unit/
2 lines

Diff 366586

compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp

Show First 20 Lines • Show All 146 Lines • ▼ Show 20 Lines static void *Func(void *arg) {
TraceMutexLock(thr, v3::EventType::kRLock, 0x4002, 0x5001, 0x6002); TraceMutexLock(thr, v3::EventType::kRLock, 0x4002, 0x5001, 0x6002);
Lock lock1(&ctx->slot_mtx); Lock lock1(&ctx->slot_mtx);
ThreadRegistryLock lock2(&ctx->thread_registry); ThreadRegistryLock lock2(&ctx->thread_registry);
VarSizeStackTrace stk; VarSizeStackTrace stk;
MutexSet mset; MutexSet mset;
uptr tag = kExternalTagNone; uptr tag = kExternalTagNone;
bool res = RestoreStack(thr->tid, v3::EventType::kLock, thr->sid, bool res = RestoreStack(thr->tid, v3::EventType::kLock, thr->sid,
thr->epoch, 0x5001, 0, 0, &stk, &mset, &tag); thr->epoch, 0x5001, 0, 0, &stk, &mset, &tag);
CHECK(res);
CHECK_EQ(stk.size, 2); CHECK_EQ(stk.size, 2);
CHECK_EQ(stk.trace[0], 0x1000); CHECK_EQ(stk.trace[0], 0x1000);
CHECK_EQ(stk.trace[1], 0x4002); CHECK_EQ(stk.trace[1], 0x4002);
CHECK_EQ(mset.Size(), 2); CHECK_EQ(mset.Size(), 2);
CHECK_EQ(mset.Get(0).addr, 0x5000); CHECK_EQ(mset.Get(0).addr, 0x5000);
CHECK_EQ(mset.Get(0).stack_id, 0x6000); CHECK_EQ(mset.Get(0).stack_id, 0x6000);
CHECK_EQ(mset.Get(0).write, true); CHECK_EQ(mset.Get(0).write, true);
CHECK_EQ(mset.Get(1).addr, 0x5001); CHECK_EQ(mset.Get(1).addr, 0x5001);
Show All 26 Lines static void *Func(void *arg) {
Lock lock1(&ctx->slot_mtx); Lock lock1(&ctx->slot_mtx);
ThreadRegistryLock lock2(&ctx->thread_registry); ThreadRegistryLock lock2(&ctx->thread_registry);
VarSizeStackTrace stk; VarSizeStackTrace stk;
MutexSet mset; MutexSet mset;
uptr tag = kExternalTagNone; uptr tag = kExternalTagNone;
bool res = bool res =
RestoreStack(thr->tid, v3::EventType::kAccessExt, thr->sid, RestoreStack(thr->tid, v3::EventType::kAccessExt, thr->sid,
thr->epoch, 0x3000, 8, kAccessRead, &stk, &mset, &tag); thr->epoch, 0x3000, 8, kAccessRead, &stk, &mset, &tag);
CHECK(res);
CHECK_EQ(stk.size, 4); CHECK_EQ(stk.size, 4);
CHECK_EQ(stk.trace[0], 0x1000); CHECK_EQ(stk.trace[0], 0x1000);
CHECK_EQ(stk.trace[1], 0x2000); CHECK_EQ(stk.trace[1], 0x2000);
CHECK_EQ(stk.trace[2], 0x4000); CHECK_EQ(stk.trace[2], 0x4000);
CHECK_EQ(stk.trace[3], 0x2002); CHECK_EQ(stk.trace[3], 0x2002);
CHECK_EQ(mset.Size(), 2); CHECK_EQ(mset.Size(), 2);
CHECK_EQ(mset.Get(0).addr, 0x5000); CHECK_EQ(mset.Get(0).addr, 0x5000);
CHECK_EQ(mset.Get(0).stack_id, 0x6000); CHECK_EQ(mset.Get(0).stack_id, 0x6000);
Show All 11 Lines